Migrate cli lookup from Cliffy to Optique - #390
Merged
Merged
Conversation
Member
Author
|
Should I upgrade node version from 24.2.1 to 24.3.o (pnpm-lock.yaml) |
Member
|
No, you don't have to. |
dahlia
reviewed
Aug 30, 2025
dahlia
left a comment
Member
There was a problem hiding this comment.
Could you replace console.log()/console.error() calls with print()/printError() provided by Optique? See also: https://optique.dev/concepts/messages#terminal-output.
- replace console.log to print, console.error to printError from optique - remove unused packages
sij411
marked this pull request as ready for review
August 30, 2025 07:58
Member
|
Seems your commits have conflicts with the current next branch. |
Contributor
|
The docs for this pull request have been published: |
2chanhaeng
reviewed
Sep 1, 2025
2chanhaeng
left a comment
Member
There was a problem hiding this comment.
Maybe it would be better to change the modules to only return command and run, then write the code like this for better consistency?
2chanhaeng
reviewed
Sep 1, 2025
5 tasks
dahlia
requested changes
Sep 1, 2025
2chanhaeng
requested changes
Sep 1, 2025
- unappropriate import alias - update pacakage version - update message text - update metavar
dahlia
requested changes
Sep 4, 2025
Contributor
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrated fedify/cli
lookupand its test from Cliffy to OptiqueRelated Issue
Changes
cli-optique. This will be a working directory for migrating entireCliffycodebase toOptique.mod.ts,lookup.tsandlookup.test.tswithoptiquelookup.ts.init.ts,nodeinfo.ts,tunnel.ts,webfinger.ts,inbox.tsBenefits
With this migration,
fedify/cliwill run natively all major runtimes such as Node.js, Deno, and Bun. Also thanks tooptiqueis type-safety and other features, future cli development and maintenance would be easier.Checklist
deno task test-allon your machine?Additional Notes
docloader.tsand 'tempserver.tsfrom originalpackages/cli`cli/