Create SvelteKit example project - #389
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @2chanhaeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new SvelteKit example application for Fedify, designed to serve as a practical guide for users looking to integrate Fedify with SvelteKit. The example demonstrates key ActivityPub features and provides a complete, runnable application with modern web development practices, making it easier for developers to get started with building federated applications.
Highlights
- New SvelteKit Example Project: A comprehensive SvelteKit example application has been added to the
examples/sveltekit-sampledirectory, demonstrating how to build a federated server using Fedify. - ActivityPub Integration: The example showcases core ActivityPub functionalities, including actor dispatching, cryptographic key pair management, and handling of 'Follow' and 'Undo' activities.
- Modern Web Stack: The project is built with SvelteKit and styled using Tailwind CSS, providing a modern and responsive user interface, along with full TypeScript support for type safety.
- Development and Deployment Guidance: A detailed
README.mdis included, covering prerequisites, setup, development server instructions, configuration options, usage scenarios, project structure, and deployment considerations. - Tooling Configuration: Standard development tooling such as ESLint and Prettier are configured for the new example, ensuring code quality and consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
github-actions
Bot
added
component/integration
There was a problem hiding this comment.
Code Review
This pull request introduces a new SvelteKit example project, which is a great addition for new users. The example is comprehensive, covering federation, actor management, and a basic UI. My review focuses on improving code quality, fixing some minor bugs, and ensuring the documentation is accurate and consistent. I've found a few issues, including a critical reference error, some potential runtime errors, and several inconsistencies in the documentation. Addressing these points will make the example more robust and easier for developers to follow.
GitHub Actions
Inactive
|
The docs for this pull request have been published: |
dahlia
left a comment
dahlia
left a comment
There was a problem hiding this comment.
Although I'm not familiar with Svelte, it looks fine in general. @robin-maki Could you review this example code?
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
GitHub Actions
Inactive
2 participants
Summary
Create SvelteKit example project.
Related Issue
Changes
examples/svelte-sampleBenefits
Now new Fedify users who use SvelteKit refer the example.
Checklist
[ ] Did you add a changelog entry to the CHANGES.md?Examples are not written in CHANGES.md.[ ] Did you write some relevant docs about this change (if it's a new feature)?Not a new feature.[ ] Did you write a regression test to reproduce the bug (if it's a bug fix)?Not a bug.[ ] Did you write some tests for this change (if it's a new feature)?deno task test-allon your machine?Additional Notes
My agent implemented too much (e.g. CSS), but it looks good so I didn't remove it.