fix(ci): remove the duplicate checkout from the setup action - #256
Open
Gaic4o wants to merge 1 commit into
Open
Conversation
|
Gaic4o
marked this pull request as ready for review
September 1, 2026 03:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the duplicate
actions/checkoutstep from.github/actions/setup.In the
bundle-size-untrustedworkflow, the base and head branches are checked out separately before running the setup action. However, the checkout inside the setup action was overwriting the selected ref, causing both jobs to build the same code. As a result, the Before and After values in the bundle size report were always the same.All workflows that use the setup action already perform a checkout beforehand, so the checkout inside the action was unnecessary.
One thing to note is that the bundle size report for this PR itself may still not fully reflect the fix, because the base job will continue to use the existing setup action from the base branch. The comparison should work correctly for PRs opened after this change is merged.