Skip to content

fix(ci): remove the duplicate checkout from the setup action - #256

Open
Gaic4o wants to merge 1 commit into
feature-sliced:masterfrom
Gaic4o:fix/setup-action-duplicate-checkout
Open

fix(ci): remove the duplicate checkout from the setup action#256
Gaic4o wants to merge 1 commit into
feature-sliced:masterfrom
Gaic4o:fix/setup-action-duplicate-checkout

Conversation

@Gaic4o

@Gaic4o Gaic4o commented Sep 1, 2026

Copy link
Copy Markdown
Member

Removed the duplicate actions/checkout step from .github/actions/setup.

In the bundle-size-untrusted workflow, the base and head branches are checked out separately before running the setup action. However, the checkout inside the setup action was overwriting the selected ref, causing both jobs to build the same code. As a result, the Before and After values in the bundle size report were always the same.

All workflows that use the setup action already perform a checkout beforehand, so the checkout inside the action was unnecessary.

One thing to note is that the bundle size report for this PR itself may still not fully reflect the fix, because the base job will continue to use the existing setup action from the base branch. The comparison should work correctly for PRs opened after this change is merged.

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 678cb2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Gaic4o
Gaic4o marked this pull request as ready for review September 1, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant