Repository navigation
Flush caches of VLAN object from new dp not old dp - #4856
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4856 +/- ##
=======================================
Coverage 91.74% 91.74%
=======================================
Files 46 46
Lines 9082 9084 +2
=======================================
+ Hits 8332 8334 +2
Misses 750 750 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cglewis
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced in #4850, when deleting a VLAN we want to remove the VLAN from the old DP configuration so that all the flowmods that were created by the old VLAN instance are deleted, however for VLANs that continue to exist in the new DP configuration (those whose configuration has changed) we want to reset the caches of the cloned and updated VLAN object that exists in new_dp.