fix: use targeted SGR reset for fg/bg colors#295
Open
mo1ein wants to merge 1 commit into
Open
Conversation
The unformat() function emitted \x1b[0m (full Reset) for foreground and background colors because they were missing from mapResetAttributes. This caused wrapping already-colorized strings with Underline to lose the underline — the inner \x1b[0m wiped out the outer formatting. Fix by: - Adding all foreground colors (→ 39) and background colors (→ 49) to mapResetAttributes - Changing unformat() to skip params not in the map instead of defaulting to Reset (0), which also fixes compound RGB sequences where numeric sub-params would cause spurious full resets Closes fatih#233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233
The
unformat()function emitted\x1b[0m(full Reset) for foreground and background colors because they were missing frommapResetAttributes. This caused wrapping already-colorized strings with Underline to lose the underline — the inner\x1b[0mwiped out the outer formatting.Fix by:
unformat()to skip params not in the map instead of defaulting to Reset (0), which also fixes compound RGB sequences where numeric sub-params would cause spurious full resets