Skip to content

Require patched Node runtimes - #8143

Merged
ComputelessComputer merged 1 commit into
mainfrom
fix/node-security-runtime
Oct 24, 2026
Merged

ComputelessComputer merged 1 commit into
mainfrom
fix/node-security-runtime

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Intent: Prevent CI and billing image builds from selecting Node versions affected by the October security advisory. Pin Node 22.23.4 and restrict supported workspace engines to patched release ranges.

Tracks ANLG-525. Production Vercel patch verification and coordinated Stripe key rotation remain separate follow-up work; this PR does not establish production remediation.

Demo

N/A — runtime and build configuration only; no user-facing UI changes.

Verification

  • Changed-file dprint formatting/check passed.
  • Repository CI Node tests: 95 passed; license-boundary checks passed with Python 3.12.
  • Stripe typecheck passed; billing tests: 105 passed, 5 isolated-Postgres tests skipped.
  • docker build --target billing-runtime -f apps/api/Dockerfile . passed.
  • Changelog/version consistency checks passed.
  • Offline zizmor scan completed with findings on existing workflow configuration; authenticated audits were unavailable.

Summary by cubic

Pins CI workflows and the billing Docker image to Node 22.23.4 and restricts workspace engines to patched releases so builds avoid Node versions affected by the October security advisory.

  • Updates the node-version pin in all five CI setup steps and the billing Docker base image.
  • Replaces the engines range >=22 with ^22.23.4 || ^24.22.1 || >=26.12.1.

Tracks ANLG-525. Production Vercel and Stripe key rotation remain separate follow-ups.

Written for commit e12f37d. Summary will update on new commits.

View guided diff Turn on auto-fix

Pin CI and the billing build image to Node 22.23.4 and exclude vulnerable Node releases from supported workspace engines.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread package.json
"packageManager": "pnpm@11.1.1",
"engines": {
"node": ">=22"
"node": "^22.23.4 || ^24.22.1 || >=26.12.1"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Linux setup can retain unsupported Node

With Node 22.0 installed, setup_toolchains leaves it unchanged despite the new engine floor. The setup guidance also still permits any Node 22 release.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@ComputelessComputer
ComputelessComputer merged commit 2d133da into main Oct 24, 2026
20 checks passed
@ComputelessComputer
ComputelessComputer deleted the fix/node-security-runtime branch October 24, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant