feat: warn on vulnerable torch versions in fal run#962
Open
wennergr wants to merge 2 commits into
Open
Conversation
Adds a security warning in `fal run` when the app's requirements include a torch version <= 2.5, which has known serialization vulnerabilities allowing malicious model files to execute arbitrary code. The warning also notes that a future release will automatically set weights_only=True on torch.load() calls for torch < 2.6 as a mitigation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Not convinced that this is the right place to put this warning ( |
badayvedat
reviewed
Apr 13, 2026
Comment on lines
+247
to
+253
| def _is_safe_version(version_str: str) -> bool: | ||
| parts = version_str.split(".") | ||
| try: | ||
| major, minor = int(parts[0]), int(parts[1]) | ||
| except (IndexError, ValueError): | ||
| return False | ||
| return major > 2 or (major == 2 and minor >= 6) |
Contributor
There was a problem hiding this comment.
fails on something like this, while it should not
from fal.cli._utils import warn_if_vulnerable_torch
from rich.console import Console
from rich.theme import Theme
console = Console(theme=Theme(), soft_wrap=True)
warn_if_vulnerable_torch(["torch>3"], console=console)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a security warning in
fal runwhen the app's requirements include a torch version <= 2.5, which has known serialization vulnerabilities allowing malicious model files to execute arbitrary code.The warning also notes that a future release will automatically set weights_only=True on torch.load() calls for torch < 2.6 as a mitigation.