Skip to content

fix: restore stencil compare value for nested masks #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
secant666 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: restore stencil compare value for nested masks #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Assets/Scripts/Core/UpdateContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public struct ClipInfo
public uint clipId;
public int rectMaskDepth;
public int referenceValue;
public int compareValue;
public bool reversed;
}

Expand Down Expand Up @@ -60,10 +61,12 @@ public void Begin()
batchingDepth = 0;
rectMaskDepth = 0;
stencilReferenceValue = 0;
stencilCompareValue = 0;
alpha = 1;
grayed = false;

clipped = false;
clipInfo = default;
_clipStack.Clear();

Stats.ObjectCount = 0;
Expand Down Expand Up @@ -181,6 +184,7 @@ public void EnterClipping(uint clipId, bool reversedMask)

clipInfo.clipId = clipId;
clipInfo.referenceValue = stencilReferenceValue;
clipInfo.compareValue = stencilCompareValue;
clipInfo.reversed = reversedMask;
clipped = true;
}
Expand All @@ -192,6 +196,7 @@ public void LeaveClipping()
{
clipInfo = _clipStack.Pop();
stencilReferenceValue = clipInfo.referenceValue;
stencilCompareValue = clipInfo.compareValue;
rectMaskDepth = clipInfo.rectMaskDepth;
clipped = stencilReferenceValue != 0 || rectMaskDepth != 0;
}
Expand All @@ -203,14 +208,19 @@ public void EnterPaintingMode()

clipInfo.rectMaskDepth = 0;
clipInfo.referenceValue = 0;
clipInfo.compareValue = 0;
clipInfo.reversed = false;
rectMaskDepth = 0;
stencilReferenceValue = 0;
stencilCompareValue = 0;
clipped = false;
}

public void LeavePaintingMode()
{
clipInfo = _clipStack.Pop();
stencilReferenceValue = clipInfo.referenceValue;
stencilCompareValue = clipInfo.compareValue;
rectMaskDepth = clipInfo.rectMaskDepth;
clipped = stencilReferenceValue != 0 || rectMaskDepth != 0;
}
Expand Down