Skip to content

Bring CI and Dependencies up to date and synchronise opencmw-cpp changes - #225

Merged
wirew0rm merged 7 commits into
mainfrom
cpp_followups
Dec 2, 2025
Merged

Bring CI and Dependencies up to date and synchronise opencmw-cpp changes#225
wirew0rm merged 7 commits into
mainfrom
cpp_followups

Conversation

@wirew0rm

@wirew0rm wirew0rm commented Dec 2, 2025

Copy link
Copy Markdown
Member

This is a small maintainance commit, no new features, just keeping up with the rest of the world moving:

  • CI: restyled switched from running their own infrastructure to running as a github action
  • JDK language level: bump from 11 to 17, since 11 is not publicly supported any more.
  • Dependencies: Bump all dependencies without breaking API changes
  • non-functional small code improvements

The only functional change is removing the unused hash field in the opencmw YaS serialiser in accordance with (fair-acc/opencmw-cpp#318).

Next step is to follow up on #223 to ensure compatibility on the network level and adding a testcase that ensures compatibility between opencmw-cpp and opencmw-java.

@wirew0rm
wirew0rm temporarily deployed to configure coverage December 2, 2025 14:58 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 2, 2025 14:58 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 2, 2025 15:01 — with GitHub Actions Inactive
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
The field name hash has been removed from opencmw-cpp [1]. This removes
the hash from the field to make the serialisation formats compatible
again.

[1] fair-acc/opencmw-cpp#318

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
Fix trivial codestyle issues like typos, simplifying the code with newer
language constructs, etc.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
…on newer java versions

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>

@RalphSteinhagen RalphSteinhagen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update/fixes. Can be merged as is once the CI passes.

@wirew0rm

wirew0rm commented Dec 2, 2025

Copy link
Copy Markdown
Member Author

Thanks for looking over this and the comments!

Network tests in the CI seem to be prone to timeout issues, which I locally cannot reproduce.

Maven Central deployment will also have to be fixed separately, looks like this might be an issue of expired deployment keys.

@wirew0rm
wirew0rm merged commit 9484097 into main Dec 2, 2025
9 of 14 checks passed
@wirew0rm
wirew0rm deleted the cpp_followups branch December 2, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants