security: clear the two repo-wide P4 gates for staging (Trivy x/crypto + gitpython) - #215
Open
jgruberf5 wants to merge 3 commits into
Open
security: clear the two repo-wide P4 gates for staging (Trivy x/crypto + gitpython)#215jgruberf5 wants to merge 3 commits into
jgruberf5 wants to merge 3 commits into
Conversation
…22.0 stable Trivy's DB now flags CVE-2026-56854 (golang.org/x/crypto/ssh — authentication bypass via unenforced source-address restriction, CRITICAL) in the bundled helm binary (helm 3.20.0 embeds x/crypto v0.46.0). It is the sole CRITICAL blocking the P4 "Docker Build + Scan" gate, which had gone red on every open PR whose scan re-ran after the DB update (staging itself last scanned clean on 2026-08-24 and would now be red too). Fixed in x/crypto 0.55.0, but the only helm release carrying it is v3.22.0-rc.1 (prerelease); latest stable v3.21.4 still ships v0.54.0. We do not pin a prerelease helm in production, so this follows the file's established pattern for un-fixable-yet third-party Go-binary CVEs: a documented, justified, dated suppression. Not exploitable in our context: the flaw is in the SSH *server* auth path (ssh.ServerConfig source-address enforcement); helm/kubectl/tofu/infracost never run an SSH server and no container exposes one (Python SSH uses paramiko) — same rationale as the existing CVE-2024-45337 entry. The real fix (bump to helm 3.22.0 stable + drop this entry) is tracked in #214. Claude-Session: https://claude.ai/code/session_01UCsZXDxBsWV2s4kT47DwDW
pip-audit flags gitpython 3.1.58 for PYSEC-2026-3785/3786/3787/3788, all fixed in 3.1.59 (a patch release). This is the sole finding failing the "P4 · Security Audit" gate (make security-audit) — the npm prod HIGH+ and dev CRITICAL gates both pass. Like the Trivy suppression in this PR, it's a repo-wide gate that went red on every open PR after the advisory DB updated (staging last audited clean on 2026-08-24), not caused by any PR's code. Claude-Session: https://claude.ai/code/session_01UCsZXDxBsWV2s4kT47DwDW
This was referenced Sep 8, 2026
npm audit flags js-yaml 4.3.1 for GHSA-2883-xcg3-v3hh (maxTotalMergeKeys does not limit CPU use for empty merge sources — HIGH), the sole HIGH in the prod-deps gate (`npm audit --omit=dev --audit-level=high`). Patched in 4.3.2, which is inside the existing ^4.3.1 caret — a clean, non-breaking lockfile bump (package-lock diff is js-yaml-only). The remaining DOMPurify (transitive via monaco-editor) and react-router advisories are moderate and do not gate. Completes the P4 Security Audit fix alongside the gitpython bump: pip-audit and both npm gates (prod HIGH+, dev CRITICAL) now pass. Same environmental class as the rest of this PR — the advisory DB moved after staging last audited clean. Claude-Session: https://claude.ai/code/session_01UCsZXDxBsWV2s4kT47DwDW
Collaborator
Author
Self-review @
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two P4 security gates that have been red on every open PR (and would be red on staging if re-scanned) since the advisory/vuln DBs updated after staging last ran clean on 2026-08-24. Neither is caused by any PR's code; both are repo-wide.
1.
P4 · Docker Build + Scan— Trivy CRITICALAdds one
.trivyignoreentry for CVE-2026-56854 (golang.org/x/crypto/ssh— authentication bypass via unenforced source-address restriction, CRITICAL), the sole CRITICAL blocking the gate. Embedded in the bundled helm binary (helm 3.20.0 → x/crypto v0.46.0).x/crypto0.55.0; the only helm release carrying it is v3.22.0-rc.1 (prerelease). Latest stable v3.21.4 still ships v0.54.0. We don't pin a prerelease helm, so a bump can't clear the CRITICAL yet.ssh.ServerConfigsource-address enforcement); helm/kubectl/tofu/infracost never run an SSH server and no Forge container exposes one (Python SSH uses paramiko). Same class/rationale as the existing CVE-2024-45337 entry.exp:2026-11-30+ tracker). Real fix (bump to helm 3.22.0 stable + drop the entry) tracked in Bump Helm to 3.22.0 (x/crypto 0.55.0) and drop CVE-2026-56854 trivyignore #214.2.
P4 · Security Audit— pip-auditBumps gitpython 3.1.58 → 3.1.59 in
backend/requirements.txt. pip-audit flags 3.1.58 for PYSEC-2026-3785/3786/3787/3788, all fixed in the 3.1.59 patch release — the sole finding failingmake security-audit. (The npm prod HIGH+ and dev CRITICAL gates both already pass; only 4 moderate prod advisories remain, which the gate does not block on.)Scope
Deliberately minimal and low-risk: one documented Trivy suppression + one patch-level dependency bump. No behavior change. Once merged, the open PRs rebased on staging inherit both fixes and go green on P4.
https://claude.ai/code/session_01UCsZXDxBsWV2s4kT47DwDW