Conversation
PThorpe92
force-pushed
the
p_icons
branch
2 times, most recently
from
October 16, 2023 17:43
c05c210 to
1609396
Compare
cafkafk
requested changes
Oct 17, 2023
cafkafk
left a comment
cafkafk
left a comment
Member
There was a problem hiding this comment.
This seems good (nice that you regenerated nix tests!), only thing is we need a convetional commits breaking change notice, because this removes --no-icons.
cafkafk
approved these changes
Oct 19, 2023
cafkafk
left a comment
cafkafk
left a comment
Member
There was a problem hiding this comment.
I think everything is in order. Merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rework of PR #54 which needed considerable work. In the manpage,
ezastated thatautowas the default color option, but I noticed that no flags actually used theTakesValue::Optionaloption.This allows
--icons- and--color` to be passed without an argument, and stops icons from being rendered when piped or in a tty.