Skip to content

(exa PR) 1070: Make symlinks report their target's size, if valid - #42

Merged
cafkafk merged 2 commits into
mainfrom
pr-1070
Jul 30, 2023
Merged

(exa PR) 1070: Make symlinks report their target's size, if valid#42
cafkafk merged 2 commits into
mainfrom
pr-1070

Conversation

@cafkafk

@cafkafk cafkafk commented Jul 29, 2023

Copy link
Copy Markdown
Member

@cafkafk cafkafk changed the title (exa PR) 1070 (exa PR) 1070: Make symlinks report their target's size, if valid Jul 29, 2023
@cafkafk cafkafk added help wanted Extra attention is needed good first issue Good for newcomers needs feedback labels Jul 29, 2023
@sbatial sbatial mentioned this pull request Jul 30, 2023
63 tasks

@sbatial sbatial left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried it on a few samples and I find it actually really nice!

One thing: Symlinks have currently set their names bytecount as their size (if i didn't miss anything).
I don't know why anyone would need that/rely on it but we should keep in mind that that might break someone nuclear powerplant.
reference: https://xkcd.com/1172/

wlritchi and others added 2 commits July 30, 2023 17:41
Co-authored-by: Luc Ritchie <luc.ritchie@gmail.com>
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
@cafkafk

cafkafk commented Jul 30, 2023

Copy link
Copy Markdown
Member Author

LGTM 👍

One thing: Symlinks have currently set their names bytecount as their size (if i didn't miss anything).

we should keep in mind that that might break someones nuclear powerplant.

git-5b713d

@cafkafk
cafkafk merged commit 08db112 into main Jul 30, 2023
@sbatial
sbatial deleted the pr-1070 branch July 30, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers help wanted Extra attention is needed needs feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants