DRAFT: feat: add option to show hidden files with underscore prefix on Windows - #1504
Draft
jschpp wants to merge 1 commit into
Draft
DRAFT: feat: add option to show hidden files with underscore prefix on Windows#1504jschpp wants to merge 1 commit into
jschpp wants to merge 1 commit into
Conversation
jschpp
marked this pull request as draft
June 10, 2025 06:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried adding a flag to show
_prefixfiles under windows. See #1233 and #1220I'm not happy with this. Adding a new boolean to Dir::files() meant touching every call site, which made the change feel more invasive than it should’ve been. There are some call sites like where I just chose a reasonable sounding default to pass along.
This is not complete and I'm not sure how to get there.
eza -T --show-hidden-underscorefor example doesn't work at the moment and I don't know quite why...@cafkafk would you mind taking a look and see if this is more like what you had in mind in #1233
closes #1220