Skip to content

sks cluster update: fix oidc config drop#881

Open
kobajagi wants to merge 2 commits into
masterfrom
predrag/sc-180059/sks-update-patch-empty-oidc-conf2
Open

sks cluster update: fix oidc config drop#881
kobajagi wants to merge 2 commits into
masterfrom
predrag/sc-180059/sks-update-patch-empty-oidc-conf2

Conversation

@kobajagi

@kobajagi kobajagi commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Fix the OIDC config getting nulled when any other attribute is updated.
API handles explicit null as empty, but it does not set nullable in OpenAPI spec which makes CLI/egoscale send explicit null.
This is why we have to set existing value in every update call.

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block, and add the Pull Request #number for each bit you add to the CHANGELOG.md)
  • Testing

Testing

$ EXOSCALE_TRACE=1 exo c sks get mycluster
..."oidc":{"client-id":"12345","username-claim":"something",...
$ go run . c sks update mycluster --description test
 ✔ Updating SKS cluster "mycluster"... 33s
...
$ EXOSCALE_TRACE=1 exo c sks get mycluster
..."oidc":{"client-id":"12345","username-claim":"something",...

@kobajagi kobajagi changed the title sks cluster update: fix oidc overwritting sks cluster update: fix oidc config drop Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant