Repository navigation
Expect the published app at evilolive.com/Dungeon-Mapper - #198
Merged
Merged
Conversation
GitHub Pages now serves the app from the account's custom domain, so the post-deploy check failed with 'Unexpected Pages destination' on every main build since 42d8dc0. The check now expects https://evilolive.com/Dungeon-Mapper/, accepts the http spelling GitHub reports for that same address, and always reads the published bytes over HTTPS. README and sharing links updated. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VkGH7MqcqEABg9gZkrkZx1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deploy job on main has failed its post-publish check since 42d8dc0 with "Unexpected Pages destination". GitHub Pages now serves the app at
evilolive.com/Dungeon-Mapper/(custom domain on the account), while the check expectedevillollive.github.io/Dungeon-Mapper/. The owner chose the evilolive.com address.Related issues
None filed.
What changed
scripts/qualification-artifact.mjs:PAGES_URLis nowhttps://evilolive.com/Dungeon-Mapper/.http://. The check accepts that spelling of the same host and path, and nothing else, and always fetches the published files over HTTPS, still with redirects treated as errors and every byte compared to the qualified build.docs/SHARING.mdlinks, changelog.Validation
qualificationArtifact.test.ts(36 passing, 1 new; the old github.io address and other paths on the new host are rejected)https://evilolive.com/Dungeon-Mapper/loads the app over HTTPSNotes for review
https://and thehttpallowance can be removed.Checklist
Generated by Claude Code