Skip to content

Bugfix: Fix drivesomethinggreater related vehicle templates #31047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaindl wants to merge 5 commits into
base: master
Choose a base branch
from
+68 −8
Open

Bugfix: Fix drivesomethinggreater related vehicle templates #31047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4bd83b6
Bugfix: Fix drivesomethinggreater related vehicle templates
kaindl Jun 20, 2026
10a26c4
rename 'vehicle-generic-online-functions' preset to 'vehicle-online'
kaindl Jun 21, 2026
f6c3329
Merge branch 'master' into bugfix_dsg_vehicle_presets
kaindl Jun 22, 2026
ed4ffa9
Remove unneeded parameters 'coarsecurrent' and 'welcomecharge' from A…
kaindl Jun 27, 2026
a96e4c3
Mention only the matching brand app in the setup instructions and cla…
kaindl Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion templates/definition/vehicle/audi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,31 @@ products:
- brand: Audi
description:
generic: EU Data Act
requirements:
description:
de: |
Nutzt die im Rahmen des EU Data Act bereitgestellten Fahrzeugdaten über das
[VW-Konzern-Portal](https://eu-data-act.drivesomethinggreater.com). Die Anmeldung
erfolgt mit den Zugangsdaten der myAudi-App.

Voraussetzung (einmalig im Browser): im Portal anmelden, die Einwilligung
bestätigen, das Fahrzeug verknüpfen und eine fortlaufende Datenanfrage
Comment thread
kaindl marked this conversation as resolved.
(alle 15 Minuten) aktivieren. Ohne diese Aktivierung liefert das Portal
keine Daten. Die Daten werden ca. alle 15 Minuten im Portal bereitgestellt.
en: |
Uses the vehicle data provided under the EU Data Act through the [VW group
portal](https://eu-data-act.drivesomethinggreater.com). Log in with the credentials
of the myAudi app.

Prerequisite (one-time, in a browser): log in to the portal, confirm the
consent screen, link the vehicle and enable a continuous data request
(every 15 minutes). Without this activation the portal returns no data.
Data is provided on the portal roughly every 15 minutes.
params:
- preset: vehicle-base
- name: vin
example: WAUZZZ...
- preset: vehicle-features

@andig andig Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

@kaindl kaindl Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already answered to your first questionmark:

vehicle-features contains "streaming", but streaming is set as mandatory in these templates. I think it is confusing for users to have a parameter in the gui, that is on even when you switched it off...

@andig andig Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naltatis could we suppress rendering params that have a non-zero default value? These can‘t be deselected anyway. Maybe limited to bool obly?

@kaindl kaindl Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andig I like your idea better, than what I did here. I created a PR with a suggestion for that: #31196

@naltatis naltatis Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we suppress rendering params that have a non-zero default value? These can‘t be deselected anyway. Maybe limited to bool obly?

Sounds like something that has potential to create confusion in the future. I'd rather keep it simple/deterministic - this would also affect the rendered docs.

Breaking up (inlining) the preset seems like the right move here. I'd rather reorganize the presets in the future, than implementing revert/hide preset params from within the template.

@andig andig Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with breaking up the presets is that you'll need to do this everywhere every time a single preset is added.

@kaindl kaindl Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the last changes this discussion is not relevant for this PR anymore -> perhaps you want to separate it from the PR, @andig , @naltatis ?

- preset: vehicle-online
render: |
type: drivesomethinggreater
brand: Audi
Expand Down
6 changes: 3 additions & 3 deletions templates/definition/vehicle/drivesomethinggreater.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ requirements:
Voraussetzung (einmalig im Browser): im Portal anmelden, die Einwilligung
bestätigen, das Fahrzeug verknüpfen und eine fortlaufende Datenanfrage
(alle 15 Minuten) aktivieren. Ohne diese Aktivierung liefert das Portal
keine Daten. Die Daten werden ca. alle 15 Minuten aktualisiert.
keine Daten. Die Daten werden ca. alle 15 Minuten im Portal bereitgestellt.
en: |
Uses the vehicle data provided under the EU Data Act through the [VW group
portal](https://eu-data-act.drivesomethinggreater.com). Log in with the credentials
Expand All @@ -36,7 +36,7 @@ requirements:
Prerequisite (one-time, in a browser): log in to the portal, confirm the
consent screen, link the vehicle and enable a continuous data request
(every 15 minutes). Without this activation the portal returns no data.
Data is refreshed roughly every 15 minutes.
Data is provided on the portal roughly every 15 minutes.
params:
- preset: vehicle-base
- name: brand
Expand All @@ -46,7 +46,7 @@ params:
description:
de: Marke
en: Brand
- preset: vehicle-features
Comment thread
kaindl marked this conversation as resolved.
- preset: vehicle-online
render: |
type: drivesomethinggreater
brand: {{ .brand }}
Expand Down
22 changes: 21 additions & 1 deletion templates/definition/vehicle/seat-cupra.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,29 @@ products:
- brand: Cupra
description:
generic: EU Data Act
requirements:
description:
de: |
Nutzt die im Rahmen des EU Data Act bereitgestellten Fahrzeugdaten über das
[VW-Konzern-Portal](https://eu-data-act.drivesomethinggreater.com). Die Anmeldung
erfolgt mit den Zugangsdaten der SEAT/CUPRA Connect App.

Voraussetzung (einmalig im Browser): im Portal anmelden, die Einwilligung
bestätigen, das Fahrzeug verknüpfen und eine fortlaufende Datenanfrage
(alle 15 Minuten) aktivieren. Ohne diese Aktivierung liefert das Portal
keine Daten. Die Daten werden ca. alle 15 Minuten im Portal bereitgestellt.
en: |
Uses the vehicle data provided under the EU Data Act through the [VW group
portal](https://eu-data-act.drivesomethinggreater.com). Log in with the credentials
of the SEAT/CUPRA Connect app.

Prerequisite (one-time, in a browser): log in to the portal, confirm the
consent screen, link the vehicle and enable a continuous data request
(every 15 minutes). Without this activation the portal returns no data.
Data is provided on the portal roughly every 15 minutes.
params:
- preset: vehicle-base
- preset: vehicle-features
- preset: vehicle-online
render: |
type: drivesomethinggreater
brand: Cupra
Expand Down
26 changes: 23 additions & 3 deletions templates/definition/vehicle/vw.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,35 @@ products:
generic: EU Data Act
requirements:
description:
de: e-Golf, e-Up, ID Familie
en: e-Golf, e-Up, ID family
de: |
e-Golf, e-Up, ID Familie

Nutzt die im Rahmen des EU Data Act bereitgestellten Fahrzeugdaten über das
[VW-Konzern-Portal](https://eu-data-act.drivesomethinggreater.com). Die Anmeldung
erfolgt mit den Zugangsdaten der Volkswagen-App / We Connect.

Voraussetzung (einmalig im Browser): im Portal anmelden, die Einwilligung
bestätigen, das Fahrzeug verknüpfen und eine fortlaufende Datenanfrage
(alle 15 Minuten) aktivieren. Ohne diese Aktivierung liefert das Portal
keine Daten. Die Daten werden ca. alle 15 Minuten im Portal bereitgestellt.
en: |
e-Golf, e-Up, ID family

Uses the vehicle data provided under the EU Data Act through the [VW group
portal](https://eu-data-act.drivesomethinggreater.com). Log in with the credentials
of the Volkswagen app / We Connect.

Prerequisite (one-time, in a browser): log in to the portal, confirm the
consent screen, link the vehicle and enable a continuous data request
(every 15 minutes). Without this activation the portal returns no data.
Data is provided on the portal roughly every 15 minutes.
params:
- preset: vehicle-base
- name: vin
example: WVWZZZ...
- name: timeout
deprecated: true
- preset: vehicle-features
- preset: vehicle-online
render: |
type: drivesomethinggreater
brand: Volkswagen
Expand Down
Loading