Include "global" folder for theme noteskins#1440
Open
joleskins wants to merge 1 commit into
Open
Conversation
this renames "sThemeSkinFolder" to "sThemeBaseSkinFolder" and adds "sThemeGlobalSkinFolder" inside the RefreshNoteSkinData method. naming follows sBaseSkinFolder/sGlobalSkinFolder also adds extra check for the theme global noteskin to LoadNoteSkinDataRecursive
poco0317
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theme specific noteskins currently only look at game folders, so there's no way to add cross-game skins with the "global" folder inside themes
this renames "sThemeSkinFolder" to "sThemeBaseSkinFolder" and adds "sThemeGlobalSkinFolder" inside the RefreshNoteSkinData method. naming follows sBaseSkinFolder/sGlobalSkinFolder
also adds an extra check for the theme global noteskin to LoadNoteSkinDataRecursive