Repository navigation
fix(smart-contract-verifier-http): expose the metrics port on the Service - #500
Open
Amadeus-22 wants to merge 1 commit into
Open
Amadeus-22 wants to merge 1 commit into
Amadeus-22 wants to merge 1 commit into
Conversation
…vice The ServiceMonitor scrapes the port named metrics, and the container declares it (6060), but the Service only exposed http, so the ServiceMonitor matched no endpoint port and nothing was scraped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
serviceMonitor.enabled=truethe chart renders a ServiceMonitor whose endpoint isport: metrics. The container declares that port (6060), but the Service only exposeshttp, so Prometheus finds no matching endpoint port and scrapes nothing.Reproduce
The Service has a single port named
http; the ServiceMonitor endpoint asks formetrics.Changes
templates/service.yaml: add themetricsport (6060 -> container portmetrics), using the existingmetricsPorthelper.make docs.The headless Service is left as it is, so the ServiceMonitor resolves the port on one Service only.
Testing
helm templatenow renders both ports on the Service andhelm lintpasses. Not tested against a running Prometheus. Note that the default config still has[metrics] enabled = false, so metrics also have to be turned on inconfigfor the endpoint to answer.🤖 Generated with Claude Code