Repository navigation
feat: support existing Secret for the engine JWT - #489
Merged
barnabasbusa merged 5 commits intoAug 7, 2026
Merged
Conversation
Add an existingJwtSecret value to reference a Secret created outside the chart (e.g. by an external secrets operator). When set, the chart-managed JWT Secret is not rendered and the jwt value is ignored. The referenced Secret must contain the JWT hex string under the key jwt.hex. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
@barnabasbusa Should be a pretty ez one but solves a lot of issues on my side (I guess for others as well) |
Collaborator
|
Could you please make sure you target all the different helm charts? Would be good to have this kind of change uniform for all EL/CLs |
Contributor
Author
|
@barnabasbusa Added the external secret on the other 12 charts, it's pretty straightforward and inlined with the reth/lightouse changes, except for eleel which has a comment above (since it's 3 secrets in one manifest). |
penumbra23
changed the title
barnabasbusa
approved these changes
Aug 7, 2026
barnabasbusa
left a comment
barnabasbusa
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — consistent existingJwtSecret pattern across all 14 charts, secret creation properly guarded, all mount points covered, chart versions bumped.
barnabasbusa
enabled auto-merge (squash)
August 7, 2026 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When configuring the JWT secret for reth + lighthouse, the secret can't be managed outside of the values file, which makes publishing values files (Git, buckets) impossible while retaining the same security standards. This PR introduces a well-known pattern of referencing external secrets for the JWT token (to all EL/CL charts).
Tests
pre-commit run --all-filesmake linthelm teston a local kind cluster