Skip to content

feat(tests): add XEN tests - #1766

Closed
jochem-brouwer wants to merge 2 commits into
ethereum:forks/amsterdamfrom
jochem-brouwer:xen-tests
Closed

feat(tests): add XEN tests#1766
jochem-brouwer wants to merge 2 commits into
ethereum:forks/amsterdamfrom
jochem-brouwer:xen-tests

Conversation

@jochem-brouwer

@jochem-brouwer jochem-brouwer commented Nov 7, 2025

Copy link
Copy Markdown
Member

🗒️ Description

This PR adds benchmark situations for the XEN mainnet contract.

🔗 Related Issues or PRs

Continuation of the now-closed PR in execution-spec-tests ethereum/execution-spec-tests#2101

✅ Checklist

Need to cleanup tests and add a test for reading existing slots, as well as writing zeros to a non-existing slot.

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@jochem-brouwer
jochem-brouwer marked this pull request as draft November 7, 2025 00:00
@SamWilsn
SamWilsn changed the base branch from forks/osaka to forks/amsterdam December 16, 2025 18:57
@marioevz

Copy link
Copy Markdown
Member

Hey @jochem-brouwer is this PR still required or could we close it? Thanks.

@jochem-brouwer

Copy link
Copy Markdown
Member Author

Yes, this is rather awkward, I have commits at home which I should have pushed, these cover the "slow blocks" XEN scenarios. These are rather specific and not the "worst case scenarios" but I think at this point we want to include this type of "realistic" test, as it covers many parts of benchmarks (multiple account calls, multiple account writes, and multiple storage updates to different accounts) from a realistic scenarios.
I'll push them when at home.

@LouisTsai-Csie

Copy link
Copy Markdown
Contributor

Hi @jochem-brouwer, any progress on XEN test? Is it ready for review 👍🏻

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

This PR has had no recent activity and has been marked as stale.

@github-actions github-actions Bot added the stale The Issue/PR has not had any activity for 60 days. PRs will be automatically closed. label May 6, 2026
@raxhvl

raxhvl commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Wondering if this is still relevant @jochem-brouwer

@jochem-brouwer

Copy link
Copy Markdown
Member Author

It's not, the generic tests now target "worse worst" cases 😄 👍

I'll close (bit of nostalgia this one). Thanks @raxhvl 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale The Issue/PR has not had any activity for 60 days. PRs will be automatically closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants