feat(tests): add XEN tests - #1766
Conversation
1355730 to
1becf4a
Compare
1becf4a to
2844dd9
Compare
|
Hey @jochem-brouwer is this PR still required or could we close it? Thanks. |
|
Yes, this is rather awkward, I have commits at home which I should have pushed, these cover the "slow blocks" XEN scenarios. These are rather specific and not the "worst case scenarios" but I think at this point we want to include this type of "realistic" test, as it covers many parts of benchmarks (multiple account calls, multiple account writes, and multiple storage updates to different accounts) from a realistic scenarios. |
|
Hi @jochem-brouwer, any progress on XEN test? Is it ready for review 👍🏻 |
|
This PR has had no recent activity and has been marked as stale. |
|
Wondering if this is still relevant @jochem-brouwer |
|
It's not, the generic tests now target "worse worst" cases 😄 👍 I'll close (bit of nostalgia this one). Thanks @raxhvl 😄 |
🗒️ Description
This PR adds benchmark situations for the XEN mainnet contract.
🔗 Related Issues or PRs
Continuation of the now-closed PR in
execution-spec-testsethereum/execution-spec-tests#2101✅ Checklist
Need to cleanup tests and add a test for reading existing slots, as well as writing zeros to a non-existing slot.
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture