feat: multi-method support and automatic container pool cleanup - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR expands the invocation capabilities of Glambdar and improves resource management by ensuring that container pools are properly cleaned up when functions are removed.
Key Changes
/invoke/:nameendpoint now supportsGET,POST,PUT,PATCH, andDELETErequests. The HTTP method is correctly captured and passed through to the function worker via thereq.methodfield.DeletePoolmethod in thePoolManagerto immediately drain idle container channels and stop all associated Docker containers when a function is deleted.valid.ziptest function to handle null headers and echo request metadata.CHANGELOG.mdfor thev2.2.1release.Verification
TestInvoke_MethodsandTestInvoke_HappyPathwithRUN_INTEGRATION_TESTS=1. All 6 method variants passed successfully.Commits
ab56760- fix: clear container pool on function delete7b5b5c7- feat: add support to other HTTP methodsc06a952- docs: update CHANGELOG.md