Preserve effective wallet keystore directory configuration - #2525
Open
a-shannon wants to merge 2 commits into
Open
Preserve effective wallet keystore directory configuration#2525a-shannon wants to merge 2 commits into
a-shannon wants to merge 2 commits into
Conversation
a-shannon
marked this pull request as ready for review
September 7, 2026 01:45
This was referenced Sep 7, 2026
a-shannon
force-pushed
the
fix/effective-wallet-secret-dir
branch
from
September 8, 2026 10:07
d017aeb to
d1daf17
Compare
Keep synchronization scenarios with their correction in ergoplatform#2511. Reuse the spendable sorting fixture already present in ergoplatform#2480.
a-shannon
force-pushed
the
fix/effective-wallet-secret-dir
branch
from
September 8, 2026 10:33
d1daf17 to
3c41051
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wallet keystore directory respects the merged configuration priorities. A post-resolution rewrite previously replaced explicit higher-priority values whenever the user file supplied only the base directory.
The reader resolves the existing directory substitution after merging configuration layers. Explicit values keep their priority, and the default follows the effective base directory. Existing keystore files are not moved.
Review and integration
Reusable candidate fixtures and the standalone selected-header observation helper are extracted into #2535, which should merge first. This branch contains that exact prerequisite followed by the settings correction in commit
3c41051323eff25f0c6000653e47621a8745a0c1.Review only the two settings files. These source and direct-test files are unchanged from the previous PR head. GitHub's upstream-master diff includes the common prerequisite until it merges; the incremental settings change contains no fixture edits.
Validation: all 13 ErgoSettingsSpecification tests pass. These results are reused because the two settings files are unchanged after rebasing; current-head CI has eight of eight successful checks. They cover system, user and application values, default derivation and restoration of temporary configuration properties. Current-head CI and integration tracker.