Replay processed input tips during peer sync - #2506
Draft
a-shannon wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peers at the same ordering height can reconnect after input blocks have been processed and remain unaware of that input chain while mining is idle. Replay the processed input tip during existing periodic sync and sync replies so normal parent and transaction retrieval can resume.
The replay uses
InputBlockMessageSpec, the existing version/UTXO/height-proximity checks, and the existing compact weak-ID convention. It selects the processed prefix, excluding an announced descendant whose transactions are still pending.Validation:
weak-blocksatc216c5b6, covering message identity, recipients, V1/V2 sync, processed-prefix selection and payload boundaries.The idle-reconnection scenario failed twice on the unchanged baseline, then passed with the replay. The extended fixture also cancels subsequent shared-state scenarios after the first failure. A local Windows lifecycle run timed out in the existing fork scenario after P2P disconnection, leaving 1 pass, 1 failure and 6 cancellations. A separate broader Windows network run ended in a native JVM error during an existing synchronizer test. These failed runs are retained separately from the successful Linux evidence.
This draft PR contains only runtime replay and direct tests. Lifecycle results apply to the combined runtime stack using the #2505 harness and #2501 dependency bootstrap. Upstream PR checks remain blocked before compilation by the unavailable
sigma-state:6.0.5-22-368a860b-SNAPSHOTdependency.The complete test extension is available on the follow-up branch at c8680dda, in three test-only commits above the unchanged #2505 head. Its two test files are identical to the final Linux validation. Existing PR heads remain unchanged for coordinated review.
#2500 and #2503 cover adjacent request admission and connection-state handling; this change covers discovery of an already processed tip.