Preserve snapshot chunk retry budget - #2437
Open
a-shannon wants to merge 1 commit into
Open
Conversation
a-shannon
force-pushed
the
fix/snapshot-chunk-retry-budget
branch
from
September 4, 2026 14:55
1793468 to
b9fde27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxDeliveryChecksbudget to terminate repeated chunk retries.Root cause
checkDeliveryincremented the stored attempt count, butrequestUtxoSetChunkrecreated theDeliveryTrackerentry without passing that count. The default value of zero replaced the previous state on every retry, so the configured maximum could never be reached for snapshot chunks.Impact
When UTXO snapshot bootstrap is enabled, an unavailable or non-delivering chunk could be requested repeatedly instead of exhausting the configured retry budget. This could prolong or stall that bootstrap mode while producing repeated peer penalties, timers, logs, and network traffic.
This change does not affect consensus rules, transaction validity, serialization, or default configuration.
Scope
The change enforces the existing retry budget. It does not alter snapshot-plan recovery after the budget is exhausted.
This is distinct from #2434, which corrects the request type used for snapshot manifest retries, and #2424, which restores wallet scanning after snapshot bootstrap. #2424 touches the same synchronizer and specification, so whichever change lands second may need a small rebase.
Validation
0/1(99expected,0observed).1/1.34/34across the synchronizer, both delivery-tracker suites, snapshot processor, and modifier-request suite.