Added support for Dremio#88
Open
scottkwalker wants to merge 5 commits into
Open
Conversation
* Added Dremio docker image to the CI integration testing. * The `vertica` docker image is missing from dockerhub and is returning 404, so the vertica test is commented out. * Added python version markers to pyarrow, pandas and numpy as they each drop support for Python 3.8 so for working with Python 3.8 we need to install the last compatible version. * in `test_database_types` re-named the variable `type` to `_type` to avoid name shadowing with the builtin Python word. * Dremio metadata tables are lazy and only update when a table is read from. In the tests this requires that after creating a new table and inserting data we need to perform a read for Dremio metadata tables to be updated. * `test_database_types` fails to match postgres and Dremio data for "FLOAT" and "DATE".
scottkwalker
force-pushed
the
dremio
branch
from
September 30, 2025 13:22
a38708a to
db8ef96
Compare
erezsh
reviewed
Oct 23, 2025
Owner
|
Overall looks good! Once I release the new sqeleton version, I think this can be merged quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Dremio docker image to the CI integration testing.
The
verticadocker image is missing from dockerhub and is returning 404, so the vertica test is commented out.Added python version markers to pyarrow, pandas and numpy as they each drop support for Python 3.8 so for working with Python 3.8 we need to install the last compatible version.
in
test_database_typesre-named the variabletypeto_typeto avoid name shadowing with the builtin Python wordtype.Dremio metadata tables are lazy and only update when a table is read from. In the tests this requires that after creating a new table and inserting data we need to perform a read for Dremio metadata tables to be updated.
test_database_typesfails to match postgres and Dremio data for "FLOAT" and "DATE", so these two are commented out.Related pull request on sqeleton. I have opened this pull request with the pyproject.toml installing this pull request from the GitHub source. When the pull request is merged and a new version of sqeleton is released, then the line can be replaced by installing from a PyPi package.