Fix issue 81#82
Merged
erezsh merged 3 commits intoAug 7, 2025
Merged
Conversation
Fix "HashDiffer may fail if differences between tables contain None and non-None values" which causes "TypeError: '<' not supported between instances of 'str' and 'NoneType'".
Owner
|
Looks good, thanks! Any chance you can include a small test to show it sorts None and str correctly? |
Author
Thank you for the fast reply and for the tests! I will add some unit tests. |
Author
|
I used a Python 3.9+ type hint "tuple[str, Sequence]" instead of Python 3.8 "Tuple[str, Sequence]". I fixed it. |
Owner
|
Fixes issue #81 . Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "HashDiffer may fail if differences between tables contain None and non-None values" which causes "TypeError: '<' not supported between instances of 'str' and 'NoneType'".