Support generic type of download file - #294
Merged
Merged
Conversation
DanSava
requested review from
HansKallekleiv,
anders-kiaer and
asnyv
as code owners
September 14, 2020 15:12
DanSava
force-pushed
the
user_download
branch
from
September 14, 2020 15:15
cebab40 to
e7f1c0f
Compare
anders-kiaer
left a comment
anders-kiaer
left a comment
Collaborator
There was a problem hiding this comment.
Looks good @DanSava 🎉 Some small suggestions to consider.
If you are busy the next days I will probably have some time next week to get this to the finish line if you want 🥅.
Contributor
Author
|
Thank you for the review and suggestions I will try to update the PR today I also need to update the |
DanSava
force-pushed
the
user_download
branch
2 times, most recently
from
September 20, 2020 06:25
f692a6f to
342f640
Compare
anders-kiaer
force-pushed
the
user_download
branch
from
September 21, 2020 09:57
5860483 to
c6f58d3
Compare
anders-kiaer
changed the title
anders-kiaer
force-pushed
the
user_download
branch
from
September 21, 2020 10:03
c6f58d3 to
4fe0caa
Compare
anders-kiaer
force-pushed
the
user_download
branch
from
September 21, 2020 10:14
4fe0caa to
dd9007b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insert a description of your pull request (PR) here, and check off the boxes below when they are done.
Contributor checklist
CHANGELOG.md, and added it if should be communicated there.