feat(separator): physics-based outlet pressure drop from mechanical d… - #2158
Open
dupuypablo wants to merge 5 commits into
Open
feat(separator): physics-based outlet pressure drop from mechanical d…#2158dupuypablo wants to merge 5 commits into
dupuypablo wants to merge 5 commits into
Conversation
…esign Add a stateless SeparatorPressureDropCalculator that derives the gas-side outlet pressure drop from the existing mechanical design. Three contributions are modelled and reported as an immutable PressureDropBreakdown: - Inlet expansion: Borda-Carnot (1 - A_n/A_v)^2 . 0.5 . rho . v_n^2 when no inlet device is fitted, otherwise the inlet device's existing K-factor (no double-counting). Override via SeparatorMechanicalDesign.setInletExpansionLossCoefficient(K). - Internals: mist eliminator Eu . 0.5 . rho_g . v_g^2 (existing setMistEliminatorDpCoeff, default 0.5 for knitmesh on scrubbers); demisting cyclone bank Eu . rho_g . v_cyc^2 on GasScrubber (existing setCycloneEulerNumber, default 4.5). - Outlet contraction: K_con . 0.5 . rho_g . v_out^2, sharp-edged default 0.5; override via setOutletContractionLossCoefficient(K). Wired into Separator via setEnhancedPressureDropCalculation(true). Off by default; existing simulations are unchanged. When enabled, run() overrides the static pressureDrop with the computed total and exposes the breakdown via getLastPressureDropBreakdown(). Calculator failures fall back to the static value silently. Includes unit tests covering Borda-Carnot, inlet device K, sharp-edged outlet K, user override, scrubber mesh + cyclones aggregation, outlet pressure consistency, and serialisability.
dupuypablo
force-pushed
the
feat/separator-pressure-drop
branch
from
May 8, 2026 09:55
c638f58 to
c828425
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…esign
Add a stateless SeparatorPressureDropCalculator that derives the gas-side outlet pressure drop from the existing mechanical design. Three contributions are modelled and reported as an immutable PressureDropBreakdown:
Inlet expansion: Borda-Carnot (1 - A_n/A_v)^2 . 0.5 . rho . v_n^2 when no inlet device is fitted, otherwise the inlet device's existing K-factor (no double-counting). Override via SeparatorMechanicalDesign.setInletExpansionLossCoefficient(K).
Internals: mist eliminator Eu . 0.5 . rho_g . v_g^2 (existing setMistEliminatorDpCoeff, default 0.5 for knitmesh on scrubbers); demisting cyclone bank Eu . rho_g . v_cyc^2 on GasScrubber (existing setCycloneEulerNumber, default 4.5).
Outlet contraction: K_con . 0.5 . rho_g . v_out^2, sharp-edged default 0.5; override via setOutletContractionLossCoefficient(K).
Wired into Separator via setEnhancedPressureDropCalculation(true). Off by default; existing simulations are unchanged. When enabled, run() overrides the static pressureDrop with the computed total and exposes the breakdown via getLastPressureDropBreakdown(). Calculator failures fall back to the static value silently. Includes unit tests covering Borda-Carnot, inlet device K, sharp-edged outlet K, user override, scrubber mesh + cyclones aggregation, outlet pressure consistency, and serialisability.
Pull Request
Thank you for contributing to NeqSim! Please complete the following checklist before requesting review:
./mvnw testruns successfullySee CONTRIBUTING.md for the full contribution process.