Fix building docs via justfile on MacOS - #14124
Open
ajaust wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the just docs build workflow to be macOS-compatible by replacing a GNU cp long option with a portable flag, and it adds cleanup for the temporary ert-testdata clone used to fetch screenshot baselines.
Changes:
- Replace
cp --recursivewithcp -rinfetch-screenshot-baselinesto support macOS. - Add cleanup of
.tmp/ert-testdataafter docs build (with a recommendation to move that cleanup into the fetch step so it also runs whensphinx-buildfails).
`cp --recursive` does not exist on MacOS so use `cp -r` instead. Also removes temporary folder after extraction of screenshot baselines.
ajaust
force-pushed
the
fix-justfile-docs-build-macos
branch
from
August 7, 2026 14:36
7cf1f8a to
6960987
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
justfile:89
git clone ... .tmp/ert-testdatawill fail on a clean checkout if the.tmpparent directory does not already exist (it isn't in the repository). The recipe should create.tmpbefore cloning to makejust build-ert-docsreliable on fresh environments.
rm -rf .tmp/ert-testdata
git clone --depth 1 --filter=blob:none --sparse https://github.com/equinor/ert-testdata.git .tmp/ert-testdata
cd .tmp/ert-testdata && git sparse-checkout set screenshotbaselines
cp -r .tmp/ert-testdata/screenshotbaselines/. .
rm -rf .tmp/ert-testdata
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14124 +/- ##
==========================================
+ Coverage 91.85% 91.92% +0.07%
==========================================
Files 484 482 -2
Lines 33581 33493 -88
==========================================
- Hits 30847 30790 -57
+ Misses 2734 2703 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
No issue attached. This showed up when working on another issue.
Approach
cp --recursivedoes not exist on MacOS so usecp -rinstead. Also removes temporary folder after extraction of screenshot baselines.git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.