Port over fmudesign - #14115
Draft
SAKavli wants to merge 14 commits into
Draft
Conversation
Contributor
Author
|
Pushing to see if the branch passes the CI at this point in the porting process. |
SAKavli
force-pushed
the
port-over-fmudesign
branch
from
August 6, 2026 11:04
56c243a to
55882dd
Compare
Examples folder containing xlsx files was leftout
Resolves imports in fmudesign src code and tests. Replaced the semeio version in metadata sheet to avoid importing semeio
These are dependencies of fmudesign
This is a temporary addition, to see that the test suite works. This will be removed later, as it should not be a cli tool.
Some tests were cluttering the test directory with files.
SAKavli
force-pushed
the
port-over-fmudesign
branch
2 times, most recently
from
August 6, 2026 11:30
e668fec to
224a3ab
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14115 +/- ##
==========================================
- Coverage 91.93% 90.92% -1.02%
==========================================
Files 481 491 +10
Lines 33474 34768 +1294
==========================================
+ Hits 30775 31612 +837
- Misses 2699 3156 +457
Flags with carried forward coverage won't be shown. Click here to find out more.
|
SAKavli
force-pushed
the
port-over-fmudesign
branch
from
August 6, 2026 11:49
224a3ab to
cac4c6d
Compare
SAKavli
force-pushed
the
port-over-fmudesign
branch
from
August 7, 2026 07:36
cac4c6d to
87eebb0
Compare
Contributor
Author
|
All tests pass after commit #87eebb0 - where all fmudesign tests were ported over. https://github.com/equinor/ert/actions/runs/31158298977/workflow?pr=14115 |
I still dont know if it should be float
This test tests that the cli tooling can be invoked from certain folder structures, but this tooling will not be a cli tool in ert.
SAKavli
force-pushed
the
port-over-fmudesign
branch
from
August 7, 2026 13:55
021e0b7 to
b23070c
Compare
My first attempt was by writing polars dataframes to excel bytestreams, but polars have a limitation where multityped columns are cast to string, such that the produced excel_to_dict dictionary differs from the one produced by the .xlsx file - where numeric values were turned to strings. This solution can be iterated on, but it gives a relatively clear framework for how one of these test data classes to generate excel bytestreams should look like. It is simply writing one row at a time in the form of lists, perhaps not the most elegant solution, but quite simple to maintain. Can find a better way of displaying the row values, as these are formatted vertically when containing a lot of elements. The idea going forward is to create test files like test_one_by_one_sensitivity.py and populate them with tests targeting specific functionalities of fmudesign. Hopefully, we can just delete some of these files as they probably test the same.
SAKavli
force-pushed
the
port-over-fmudesign
branch
from
August 7, 2026 13:57
b23070c to
d59b367
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #13957
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.