Backup - #13989
Draft
SAKavli wants to merge 3 commits into
Draft
Conversation
Replace the separate export_observations and convert_observations commands with a single convert_observations command that uses a --format flag to select the target format. The converter functions now take a config path string directly instead of an argparse Namespace, making them easier to call programmatically and test in isolation. Removes the ERT_FEATURE_GATHER_OBS feature gate and the async API-based observation fetching code, which is superseded by reading directly from ErtConfig in the next commit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13989 +/- ##
==========================================
+ Coverage 91.34% 91.45% +0.10%
==========================================
Files 476 482 +6
Lines 34044 34114 +70
==========================================
+ Hits 31099 31200 +101
+ Misses 2945 2914 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BulkConfigConverter now accepts a list of observations and an optional ShapeRegistry directly, removing the need to spin up a storage API server to fetch data. Localization is resolved via ShapeRegistry lookup on each observation's shape_id, replacing the old dict-of-lists approach. Rewrite unit tests to construct observation model objects directly. Add a test verifying BPR observations populate i,j,k columns. Remove the old UI test that depended on the storage API flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable