Locked Scrolling in Dashboard fragment - #951
Open
Akash-Ramjyothi wants to merge 1 commit into
Open
Conversation
Contributor
|
@Akash-Ramjyothi I think the reason it's scrollable is for small screens. 🤔 |
Contributor
Author
|
@cdhiraj40 since the app is responsive, that would not be an issue right. |
Contributor
What do you mean by responsive? Can you try the dashboard fragment on a small screen in an emulator? I think if you lock there then only some of the part will be shown |
Contributor
Author
|
@cdhiraj40 that is a really good idea to test this case. I will perform the required action and update. |
Contributor
|
As far as I can say is that the Dashboard screen is not shown in his full shape on my smartphone, which has a smaller screen. Thus, it necessary that scrolling is enabled. Have you checked it in an emulator as mentioned in your previous comment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #950.
Description:
Programmatically have set the
NestedScrollingEnabledin theDashboardfragment to befalseas there is no generic requirement for this particular screen to beScrollable. It would also improve the user experience and interaction within the screen while navigating.Current Dashboard fragment:
WhatsApp.Video.2022-08-16.at.8.45.43.PM.mp4
Scrolling locked Dashboard fragment:
WhatsApp.Video.2022-08-16.at.8.25.30.PM.mp4