Skip to content

Password authentication made stronger. Error messages more informative #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pree-T wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Password authentication made stronger. Error messages more informative #882

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c81709
Password authentication made stronger.Error password and username mes…
pree-T Jan 13, 2022
9592c24
requested changes made.
pree-T Jan 30, 2022
b0b92ab
Merge branch 'enviroCar:master' into master
pree-T Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions org.envirocar.app/res/values/strings_activity_login.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
<string name="action_sign_in_register">Register</string>
<string name="action_sign_in_short">Sign in</string>
<string name="error_invalid_email">This email address is invalid.</string>
<string name="error_invalid_password">This password is too short.</string>
<string name="error_invalid_password">This password is too short.Password must be of atleast 6 characters.</string>

@asaikarthikeya asaikarthikeya Jan 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space after full-stop.

<string name="error_incorrect_password">This password is incorrect.</string>
<string name="error_invalid_credentials">Username or password is incorrect</string>
<string name="error_field_required">This field is required.</string>
<string name="error_not_connected_to_network">Not connected to network</string>
<string name="register_progress_signing_in">Registering&#8230;</string>
<string name="error_passwords_not_matching">The passwords do not match.</string>
<string name="error_invalid_username">This username is too short.</string>
<string name="error_invalid_username">This username is too short. Username must be of atleast 6 characters.</string>
<string name="error_username_contain_special">Special symbol not allowed except underscore</string>
<string name="error_field_weak_password">Password must contain at least one uppercase letter, one lowercase letter and one digit</string>

Expand Down