Skip to content

Fix up the residual blocks and layer normalization #1

Description

@engichang1467

Based on the architecture on the graph, my implementation might be wrong because they draw the layer normalization between the residual blocks. You have Pre-Ln and Post-Ln -> https://arxiv.org/abs/2002.04745

Andrej Karpathy's videos are pretty amazing. Andrej is building GPT2 from scratch. You might want to check your implementation against his. 😃 https://www.youtube.com/watch?v=kCc8FmEb1nY

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions