style: realign struct tags flagged by golines - #541
Merged
Conversation
Dropping the zero-value default tags shortened the bun tags in these two structs, which moved the column golines aligns them to. The lines were already over the limit beforehand, but golangci-lint runs with --new-from-rev, so they were only linted once the sweep touched them. Formatted with github.com/golangci/golines v0.15.0, which is the fork golangci-lint v2.12.2 embeds. segmentio/golines formats these files differently and leaves the lint failing, which is what let this through the first time. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FXYnxBszfwkNUeeAcVSSNf
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
trenova | ecf968d | Aug 12 2026, 04:01 AM |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request adjusts whitespace alignment in ChangesStruct Field Alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#540 merged with the Lint check red. This fixes the two golines findings it reported, restoring that check on
master.Dropping the zero-value
default:tags in #540 shortened the bun tags in these two structs, which moved the column golines aligns them to. The lines were already over the limit beforehand, but golangci-lint runs with--new-from-rev, so they were only linted once the sweep touched them.Related Issue or Discussion
Follow-up to #540. Failing job: https://github.com/emoss08/Trenova/actions/runs/31560662772/job/94002078090
Type of Change
Scope
internal/core/domain/distancecontrol/distancecontrol.goandinternal/core/domain/tenant/agentcontrol.go— struct tag padding only, 21 lines across the two files. No declarations, types, tag contents or validation rules change.Formatted with
github.com/golangci/golinesv0.15.0, which is the fork golangci-lint v2.12.2 embeds. Worth recording, becausesegmentio/golinesformats these two files differently and reports them clean — that is what let the failure through on #540 when I checked locally.Only the two files CI flagged are touched. Running the fork across all of
internal/core/domain/wants to reformat 42 files and roughly 2500 lines of pre-existing drift, which--new-from-revcorrectly leaves out of scope here.Validation
cd services/tms && task test— passescd services/tms && task lint— not run. golangci-lint does not start in this environment: it is built against Go 1.25 while the module targets Go 1.26 and exits withcan't load config. This change was instead produced by running the exact golines fork and version that golangci-lint embeds, so its output should match byte for byte. CI is the real check.cd client && pnpm build— no client changescd client && pnpm lint— no client changesgo build ./internal/core/domain/...— cleanDeployment Notes
Formatting only. No behaviour, schema, config or migration changes.
Workers Builds: trenovais expected to stay red. It has failed identically across #536, #537, #539 and #540, including on PRs that change no client files at all, and its logs sit behind an authenticated Cloudflare dashboard. It needs someone with dashboard access.Checklist
AGENTS.md,CLAUDE.md, and existing repository patterns.Generated by Claude Code
Summary by CodeRabbit