Skip to content

Fix post-event schedule appearing as empty - #2380

Open
rixx wants to merge 1 commit into
emfcamp:mainfrom
rixx:gh-2368
Open

Fix post-event schedule appearing as empty#2380
rixx wants to merge 1 commit into
emfcamp:mainfrom
rixx:gh-2368

Conversation

@rixx

@rixx rixx commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

closes #2368

@marksteward

marksteward commented Aug 5, 2026

Copy link
Copy Markdown
Member

This breaks filtering on finished occurrences. I think it's better just to default includeFinished to true once the event's over. Or ignore it, but again only once the event is over.

@rixx

rixx commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Hmm, my test setup must be wonky, it didn't break filtering for me. It took me a bit to figure out how to make a schedule appear in testing, so I must have gotten something wrong along the way. Sorry for the noise.

Updated to do it the way you suggested.

Slightly janky because now, the "Include finished events" checkbox does nothing after the event (unchecking it doesn't give you an empty page, which would be the alternative, but not really any better). Do you want to disable or hide the filter option once the event is over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

post-event schedule view is not very user-friendly

2 participants