Fix post-event schedule appearing as empty - #2380
Open
rixx wants to merge 1 commit into
Open
Conversation
Member
|
This breaks filtering on finished occurrences. I think it's better just to default includeFinished to true once the event's over. Or ignore it, but again only once the event is over. |
Contributor
Author
|
Hmm, my test setup must be wonky, it didn't break filtering for me. It took me a bit to figure out how to make a schedule appear in testing, so I must have gotten something wrong along the way. Sorry for the noise. Updated to do it the way you suggested. Slightly janky because now, the "Include finished events" checkbox does nothing after the event (unchecking it doesn't give you an empty page, which would be the alternative, but not really any better). Do you want to disable or hide the filter option once the event is over? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2368