-
Notifications
You must be signed in to change notification settings - Fork 79
Multi fidelity acquisition functions and recommender logic #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jpenn2023
wants to merge
22
commits into
dev/mfbo
Choose a base branch
from
dev-mfbo-main-acquisition-functions
base: dev/mfbo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+564
−14
Draft
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7416c1c
Add acquisition functions
jpenn2023 6e7faf6
Add acquisition functions
jpenn2023 524f2a3
Moving generic dict comparison validator
jpenn2023 dd25cf3
Adding qMFKG botorch attributes and including qKG current_value attri…
jpenn2023 676343e
Add SearchSpaceTaskType to searchspace init file
jpenn2023 1ac9032
Add multi fidelity acqfs to acquistion init files
jpenn2023 742ba79
Add multi-fidelity acquisiton arguments
jpenn2023 6bc1c81
Add recommender logic.
jpenn2023 0e08648
Checkpoint files should not be in the merge.
jpenn2023 9cd167a
Attrs usage for custom acqf, minor bug fixes and docstring updates
jpenn2023 196e9f8
Validation typing fix
jpenn2023 7df5fc9
Typing fixes: working around broad Botorch typing
jpenn2023 9c72a21
searchspace dependent acquisition function choice
jpenn2023 d86cd1d
MFUCB fidelities costs and values set at acqf build time
jpenn2023 e5069e7
Comp rep fidelity dictionary for MFUCB
jpenn2023 43ab6ee
Restricted searchspace for MFUCB stage one
jpenn2023 4bad23c
Fixed custom acqf imports
jpenn2023 89482b6
Fix typing in acqf builder
jpenn2023 c9d92d9
Docstring and typing fixes.
jpenn2023 d16d699
Minor fixes
jpenn2023 8f6ded1
Docstrings, error messages, variable names, file structure.
jpenn2023 5b5d1ea
Use private API
AVHopp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| """Custom acquisition functions.""" | ||
|
|
||
| from baybe.acquisition.custom_acqfs.two_stage import ( | ||
| MultiFidelityUpperConfidenceBound, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| # Multi fidelity acquisition functions | ||
| "MultiFidelityUpperConfidenceBound", | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.