Repository navigation
Remove ember-cli-fastboot from test-app - #797
Merged
SergeAstapov merged 1 commit intoMay 10, 2026
Merged
SergeAstapov merged 1 commit into
SergeAstapov merged 1 commit into
Conversation
Collaborator
|
for context, fastboot test was to avoid regression like #189 |
Contributor
DOMRect is a standard web api, and any SSR solution worth anything will need to have that available 🙈 |
Drops `ember-cli-fastboot`, `ember-cli-fastboot-testing`, the lone
`tests/fastboot/if-demo-test.js`, and the `fastbootDependencies` block
from `test-app/package.json`. There's no FastBoot runtime behavior the
addon's own tests rely on; the `typeof FastBoot === 'undefined'` guard
inside `addon/src/components/animated-each.gts` is a defensive runtime
check for downstream consumers and stays in place.
Note: ember-modal-dialog is unused in the test-app source, but the
`4.0.0` pnpm override at the repo root is left in place because
`docs/`'s `ember-cli-addon-docs` chain depends on it transitively, and
floating to `4.1.5` breaks the docs search-functionality acceptance
test.
One subtle side effect of removing fastboot: ember-auto-import's
webpack pipeline no longer extracts `@ember/test-helpers`' CSS into a
separate chunk linked early in `<head>`. The same CSS is now inlined
into JS and injected by `style-loader` at runtime — *after* the
`tests/index.html` inline override — so the default
`#ember-testing { transform: scale(0.5); width: 200% }` was beating
the override and bounds-based tests measured at half size
(`160.5 vs 321`, `actual: 50 expected: 100`, etc.). Fixed by adding
`!important` to the existing inline override so it wins regardless of
injection order.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
force-pushed
the
ai-agent/remove-modal-dialog-and-fastboot
branch
from
May 8, 2026 19:03
5b248a3 to
02c0e9e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops
ember-cli-fastboot,ember-cli-fastboot-testing, the lonetests/fastboot/if-demo-test.js, and thefastbootDependenciesblock fromtest-app/package.json. There's no FastBoot runtime behavior the addon's own tests rely on. (Thetypeof FastBoot === 'undefined'guard insideaddon/src/components/animated-each.gtsis a defensive check for downstream consumers and stays.)Adds
!importantto the existing inline#ember-testing { transform: none }override intest-app/tests/index.html— see below for why.What about ember-modal-dialog?
The
4.0.0pnpm override is left in place. Test-app source never imported it, butdocs/'sember-cli-addon-docschain depends on it transitively, and floating to4.1.5breaks the docs search-functionality acceptance test (waitFor timed out waiting for selector \"[data-test-search-result-list]\"). I tried removing it and CI surfaced the regression — separate cleanup, separate PR.Why the
!importantRemoving
ember-cli-fastbootshifts ember-auto-import's webpack pipeline: with fastboot,@ember/test-helpers' CSS gets extracted into a separate chunk linked in<head>before the inline override. Without fastboot, the same CSS is inlined into JS and injected viastyle-loaderat runtime — after the inline override. Same specificity, later rule wins, so the default#ember-testing { transform: scale(0.5); width: 200% }was beating the override and bounds-based tests started measuring at half size:!importantresolves the ordering issue regardless of how/when test-helpers' CSS gets injected.Test plan
pnpm --filter test-app test:ember→ 255 pass, 0 fail, 5 skip (was 256/0/5; net -1 is the deletedif-demo-test).pnpm lintclean in bothaddon/andtest-app/.pnpm --filter ember-animated buildsucceeds.🤖 Generated with Claude Code