Repository navigation
Conversation
|
Welcome! Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing. |
Member
Author
|
Zweitmodell-Review (Cloud-Bot): ✅ inhaltlich unbedenklich – formales Gate bleibt offen.
Generated by Claude Code |
lukisch
commented
Nov 10, 2026
lukisch
left a comment
Member
Author
There was a problem hiding this comment.
Zweitprüfung (Head 3ce49b7): keine Einwände, freigabefähig.
- Einzeilige Manifest-Änderung in
ellmos-module.v2.json:source_of_truth.typevonlocal-directoryaufgit-repository. Das passt zum bereits gesetztenrepository-Feld. - Im Repo liest kein Code und kein Test den alten Wert
local-directory; es bricht also nichts. - Lokal am Head ausgeführt:
pytest -q→ 388 passed, 4 skipped (fehlende optionale Abhängigkeitenfastapiundcompanion-for-agy). - CI am Head: alle Testjobs (3 OS × Python 3.10–3.13) und CodeQL grün.
Nicht geprüft: ob externe Konsumenten des Manifests (z. B. Registry oder Validator in anderen Repos) den Wert git-repository im Schema zulassen. Formales Approve ist nicht möglich, weil der PR vom selben Account stammt.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update source_of_truth.type from local-directory to git-repository for catalog alignment.