Skip to content

Redesign Light & Sun end to end - #1556

Merged
elkimek merged 7 commits into
mainfrom
agent/light-sun-overhaul
Aug 15, 2026
Merged

Redesign Light & Sun end to end#1556
elkimek merged 7 commits into
mainfrom
agent/light-sun-overhaul

Conversation

@elkimek

@elkimek elkimek commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • redesign the complete Light & Sun experience across current conditions, setup, live and past sessions, weekly guidance, devices, indoor environments, and measurement tools
  • present light channels as plain-language stimulation context rather than quotas, while keeping vitamin D estimates visible and useful
  • add privacy-rounded postal and optional current-location context for more local sun conditions
  • keep sunlight and device sessions distinct, with numerical UV outputs shown only when the available spectrum and distance information support them
  • strengthen burn, eye, heat, photosensitivity, glass, and uncertainty guidance throughout the workflow
  • prefer the phone ambient-light sensor for lux readings, with calibrated camera and manual fallbacks
  • release the overhaul as v1.16.0 with a user-readable changelog

User impact

Light & Sun now works as one coherent photobiology feature from setup through daily use and review. Users can understand outdoor and indoor light context without being pushed toward biological targets, while exposure estimates and device guidance remain bounded by the data actually available.

Validation

  • full checkJs, server, and service-worker type checks
  • architecture map and cycle checks
  • production bundle and performance-budget check
  • quality guardrails
  • supply-chain validation
  • focused Node regression suites for Sun, devices, indoor light, tools, context, API, and changelog
  • 38 focused Chromium/Playwright Light & Sun flows

@elkimek

elkimek commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@greptile-apps bypass the file limit and review

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The latest commit completes the postal-lookup cancellation fix by making throttle waits abortable and releasing bounded queue capacity when a caller disconnects.

  • Adds abort-aware waiting and idempotent queue-slot release.
  • Preserves serialized upstream starts while allowing replacement requests after cancellation.
  • Adds regression coverage for disconnecting a throttled lookup at queue capacity.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
api/postal-geocode.js Adds abort propagation to the throttle and releases queue accounting exactly once on cancellation or settlement.
tests/api-network-runtime.test.js Verifies that aborting a throttled postal lookup frees capacity for a replacement request.
js/sun-location.js The previously reported temporary-location issue is resolved through the setup runtime and “Use home instead” action.
data/light-device-presets.json Changes device spectrum and mode metadata, but no eligible follow-up finding is tied to a prior thread.

Reviews (6): Last reviewed commit: "Release aborted postal queue slots" | Re-trigger Greptile

Comment thread api/postal-geocode.js
Comment thread js/sun-location.js
@elkimek

elkimek commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@greptile-apps bypass the file limit and review the latest commit.

@elkimek

elkimek commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@greptile-apps bypass the file limit and review the latest commit 00fc310.

Comment thread api/postal-geocode.js Outdated
@elkimek

elkimek commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@greptile-apps bypass the file limit and review the latest commit d79be60.

@elkimek

elkimek commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@greptile-apps ignore and bypass the file-size limit, then review the latest commit 285553f in full.

@elkimek

elkimek commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@greptile-apps ignore and bypass the file-size limit, then review the latest commit bed9b31 in full. This commit addresses the aborted postal lookup queue-capacity finding from your previous review.

@elkimek
elkimek merged commit 3773a0f into main Aug 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant