Skip to content

Partially fix issues with #450, Mint Reduce Reponses. - #510

Closed
crova wants to merge 4 commits into
elixir-tesla:masterfrom
crova:issue-#450-mint-reduce-response-doesnt-handle-all-possible-responses
Closed

Partially fix issues with #450, Mint Reduce Reponses.#510
crova wants to merge 4 commits into
elixir-tesla:masterfrom
crova:issue-#450-mint-reduce-response-doesnt-handle-all-possible-responses

Conversation

@crova

@crova crova commented Dec 22, 2021 •
edited
Loading

Copy link
Copy Markdown

This PR handles {:push_promise, request_ref(), promised_request_ref :: request_ref(), headers()}.
And also {:error, ref, error} that seems to be missing as well.

Let me know if I can improve this @teamon .

@teamon

teamon commented May 8, 2022

Copy link
Copy Markdown
Member

Awesome!

@crova Can we write some tests for this?

@teamon teamon linked an issue May 8, 2022 that may be closed by this pull request
Mint reduce_responses doesn't handle all possible responses #450
Closed
@teamon teamon added mint Issues related to mint adapter fix 🧯 labels May 8, 2022
@crova

crova commented May 9, 2022

Copy link
Copy Markdown
Author

Sure @teamon , I'll try to get that done this week.

@yordis

yordis commented May 30, 2022

Copy link
Copy Markdown
Member

@crova any updates on this one?

@crova

crova commented May 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

Sorry folks, I lost track of this one.
I'll get back to this ASAP.

Edit: Just FYI, I've started looking at adding tests to this PR. It's been a long time since I touch this so I'll need to do some catching up to remember where I left this one.
Sorry it's taking too long but I've been busy lately.
I'll try to submit something as quick as I can.

Cheers.

@crova

crova commented Jun 21, 2022

Copy link
Copy Markdown
Author

Hey folks, how is it going?
I might need some help on how to properly test this.
Being a private function I'm having trouble to find a clean way to validate the changes.
Anyone with more familiarity/knowledge has any suggestions on how to tackle this?

Cheers.

@yordis
yordis force-pushed the master branch 6 times, most recently from 2bca420 to fe7207c Compare October 24, 2024 16:11
@yordis

yordis commented Aug 28, 2025

Copy link
Copy Markdown
Member

closing in favor of #803

@yordis yordis closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@crova crova

Labels

fix 🧯 mint Issues related to mint adapter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mint reduce_responses doesn't handle all possible responses

3 participants

@crova @teamon @yordis