Elliptical Rects - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the core
nkRectangleprimitive with independent horizontal and vertical radii for each corner. This allows making "elliptical corners" which generalize the circular corners. They can fallback to previous circle forms and the SDF / Shader code is optimized for that case (e.g. rx == ry).Changes
cornerRadiiYfield andNfEllipticalCornersflag while preserving existing circular-corner behavior.rx == ry.Compatibility
Existing nodes remain circular unless
NfEllipticalCornersis set. In elliptical mode,cornerssupplies the X radii andcornerRadiiYsupplies the Y radii:Setting every X radius to half the rectangle width and every Y radius to half its height produces a filled ellipse.
Figis now exactly 256 bytes. Circular backend calls remain source-compatible through automatic promotion to equal X/Y axes.Validation
nim r tests/tfignodes_helpers.nimnim r tests/trenderfragments.nimnim r tests/ttransform.nimnim c examples/siwin_cell_grid.nimsiwin_cell_gridmeasured approximately 119.9 FPS using Metal on an Apple M3 Pro.