Fix/gcp etag issue - #3
Merged
Merged
Conversation
Author
|
So, about the fix itself: We're removing goto statement, which skips 4 blocks, responsble for:
So, nothing critical here... At the moment we're getting error because this statement is skipped: found_object_size = true; but the object size is definitely found, otherwise we should goto even earlier here: if (s_discover_object_range_and_size(...)) Thus this specific goto statement looks more like a bug, which not was discovered by maintainers yet, because they only test on AWS API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/elastio/elastio/issues/11400
This PR contains rebase of existing changes to last release tag of mountpoint-s3 v1.23.0.
Also it updates aws-c-s3 submodule to fix the GCP issue.
See actual commit meassage describing the fix.