Skip to content

[EuiIcon] Add translate icon - #9842

Merged
weronikaolejniczak merged 1 commit into
elastic:mainfrom
MichaelMarcialis:translate-icon
Jul 27, 2026
Merged

[EuiIcon] Add translate icon#9842
weronikaolejniczak merged 1 commit into
elastic:mainfrom
MichaelMarcialis:translate-icon

Conversation

@MichaelMarcialis

@MichaelMarcialis MichaelMarcialis commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Screenshots

image image

Impact Assessment

Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.

Impact level: 🟢 None

Release Readiness

QA instructions for reviewer

  • Open EuiIcon documentation page.
  • Confirm that translate icon appears.
  • Confirm that translate icon renders properly in both light/dark modes.

Checklist before marking Ready for Review

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

@MichaelMarcialis
MichaelMarcialis marked this pull request as ready for review July 23, 2026 19:22
@MichaelMarcialis
MichaelMarcialis requested a review from a team as a code owner July 23, 2026 19:22
Copilot AI review requested due to automatic review settings July 23, 2026 19:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new translate glyph to EUI’s icon set to address the need for a canonical “translate” action icon (ref #9816), making it available via EuiIcon and included in the normal icon test/snapshot coverage.

Changes:

  • Added the translate SVG source and generated React icon asset.
  • Registered the new icon in typeToPathMap (with search synonyms) so it can be referenced by type="translate".
  • Updated EuiIcon snapshot coverage and added an upcoming changelog entry.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/eui/src/components/icon/svgs/translate.svg Adds the raw 16x16 SVG source for the new icon.
packages/eui/src/components/icon/assets/translate.tsx Adds the generated React component wrapper for the SVG.
packages/eui/src/components/icon/icon_map.ts Registers translate in the icon type map with metadata/synonyms.
packages/eui/src/components/icon/snapshots/icon.test.tsx.snap Updates snapshots to include rendering of the new translate icon.
packages/eui/changelogs/upcoming/9842.md Adds an upcoming changelog entry for the new icon.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@elastic-vault-github-plugin-prod

Copy link
Copy Markdown
2 visual difference(s) found - expand to review, then click Approve visual changes to update baselines

euiicon (2 differences)

StoryBeforeAfterDiff
all icons desktop
all icons mobile

@weronikaolejniczak weronikaolejniczak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🟢 Thanks, Michael!

@MichaelMarcialis

Copy link
Copy Markdown
Contributor Author

buildkite test it

@weronikaolejniczak weronikaolejniczak added skip-vrt Skips Visual Regression Testing job in CI (clearly state why you're using it in your PR) and removed skip-vrt Skips Visual Regression Testing job in CI (clearly state why you're using it in your PR) labels Jul 27, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💚 Build Succeeded

History

@weronikaolejniczak
weronikaolejniczak merged commit babb4f1 into elastic:main Jul 27, 2026
7 checks passed
@MichaelMarcialis
MichaelMarcialis deleted the translate-icon branch July 27, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EuiIcon] Add a "translate" glyph

3 participants