Skip to content

[beatreceiver] Remove exception for packetbeat when setting shutdown_timeout - #52275

Merged
khushijain21 merged 2 commits into
elastic:mainfrom
khushijain21:remove-packetbeat-exception
Jul 30, 2026
Merged

[beatreceiver] Remove exception for packetbeat when setting shutdown_timeout#52275
khushijain21 merged 2 commits into
elastic:mainfrom
khushijain21:remove-packetbeat-exception

Conversation

@khushijain21

@khushijain21 khushijain21 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

We did not set shutdown_timeout field on packetbeat receiver as it had a different semantic meaning. See issue #52005

But this has been fixed in #52005, hence removing this exception

@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • /test : Run the Buildkite pipeline.

@mergify

mergify Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@khushijain21 khushijain21 changed the title Remove exception for packetbeat when setting shutdown_timeout [beatreceiver] Remove exception for packetbeat when setting shutdown_timeout Jul 27, 2026
@khushijain21 khushijain21 added skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jul 27, 2026
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 27, 2026
@khushijain21
khushijain21 marked this pull request as ready for review July 27, 2026 13:56
@khushijain21
khushijain21 requested a review from a team as a code owner July 27, 2026 13:56
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@belimawr belimawr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khushijain21 the tests are failing because shutdown_timeout is now set for Packetbeat. Could you take a look and update the tests?

@belimawr
belimawr self-requested a review July 27, 2026 15:47
@khushijain21
khushijain21 enabled auto-merge (squash) July 30, 2026 09:19
@khushijain21
khushijain21 merged commit 43ae877 into elastic:main Jul 30, 2026
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants