[beatreceiver] Remove exception for packetbeat when setting shutdown_timeout - #52275
Merged
khushijain21 merged 2 commits intoJul 30, 2026
Merged
Conversation
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
shutdown_timeout
khushijain21
marked this pull request as ready for review
July 27, 2026 13:56
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
swiatekm
approved these changes
Jul 27, 2026
cmacknz
approved these changes
Jul 27, 2026
belimawr
approved these changes
Jul 27, 2026
belimawr
reviewed
Jul 27, 2026
belimawr
left a comment
Member
There was a problem hiding this comment.
@khushijain21 the tests are failing because shutdown_timeout is now set for Packetbeat. Could you take a look and update the tests?
belimawr
self-requested a review
July 27, 2026 15:47
khushijain21
enabled auto-merge (squash)
July 30, 2026 09:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
We did not set
shutdown_timeoutfield on packetbeat receiver as it had a different semantic meaning. See issue #52005But this has been fixed in #52005, hence removing this exception