[9.4](backport #52005) [beatreceiver][packetbeat] Delegate shutdown_timeout logic to libbeat

[mergify]

Proposed commit message

This PR delegatesshutdown_timeout logic to libbeat. It stays consistent with how other beats also handle the same.

This is also required so that we do not wait for shutdown_timeout period every time the config is validated here

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
• I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

None

Will also close #52031

---

This is an automatic backport of pull request #52005 done by Mergify.

[mergify]

Cherry-pick of 663f454 has failed:

On branch mergify/bp/9.4/pr-52005
Your branch is up to date with 'origin/9.4'.

You are currently cherry-picking commit 663f45459.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   packetbeat/config/config.go
	modified:   packetbeat/tests/system/config/packetbeat.yml.j2
	modified:   packetbeat/tests/system/test_0060_flows.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   packetbeat/beater/packetbeat.go
	both modified:   packetbeat/beater/processor.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[github-actions]

🤖 GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
• /test : Run the Buildkite pipeline.

[infra-vault-gh-plugin-prod]

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

[mergify]

This pull request has not been merged yet. Could you please review and merge it @khushijain21? 🙏

[github-actions]

TL;DR

The Buildkite failure is caused by unresolved cherry-pick conflict markers in packetbeat/beater/packetbeat.go and packetbeat/beater/processor.go, not by a Packetbeat runtime or dependency failure. Resolve both conflicts and update the backport branch before rerunning CI.

Remediation

• Resolve the conflict blocks in packetbeat/beater/packetbeat.go and packetbeat/beater/processor.go; remove all <<<<<<<, =======, and >>>>>>> markers while preserving the intended shutdown_timeout delegation and publish_timeout behavior.
• Rerun make -C packetbeat check update, make check-no-changes, and pre-commit run --all-files.

Investigation details

Root Cause

The backport commit could not be cleanly applied. The PR diff still contains conflict markers at packetbeat/beater/packetbeat.go:100-111 and packetbeat/beater/processor.go:52-69. The processor.go conflict also combines the old shutdownTimeout implementation with the incoming publishTimeout implementation, so it requires a semantic resolution rather than simply deleting markers.

Evidence

• Build: https://buildkite.com/elastic/beats/builds/50345
• Job/steps: Packetbeat Run check/update and Run pre-commit
• goimports failed with packetbeat/beater/packetbeat.go:100:1: expected statement, found '<<' and packetbeat/beater/processor.go:52:1: expected '}', found '<<'.
• The pre-commit check-merge-conflict hook reported Merge conflict string '<<<<<<<' found in packetbeat/beater/processor.go:52 and packetbeat/beater/packetbeat.go:100, plus the corresponding ======= and >>>>>>> markers.
• The PR already has the conflicts label and the earlier Mergify comment reports both files as unmerged paths.

Verification

The failure is directly confirmed by both independent CI steps; no additional tests were run because the source does not parse until the conflicts are resolved.

---

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

[khushijain21]

Resolved the cherry-pick conflicts and pushed.

9.4 adaptation: #51136 (libbeat drain watchdog / Beat.ShutdownTimeout) is not on 9.4, so this adds the Beat.ShutdownTimeout field for the beater assignment (forward-compatible). Processor flush wait uses publish_timeout so CheckConfig no longer blocks on shutdown_timeout. Kept existing status-reporter APIs; did not pull main-only logger changes from #51631.

Packetbeat beater/config compile cleanly locally.

[github-actions]

TL;DR

The golangci-lint step fails on Ubuntu, Windows, and macOS with the same four new Packetbeat findings: two forbidden logp.L calls, one WaitGroup modernization issue, and one deprecated b.Manager.Start call. Update the backport branch to address these findings, then rerun the lint workflow.

Remediation

• Replace the diagnostic-hook and pipeline warning uses of global logp.L() in packetbeat/beater/packetbeat.go with the appropriate logger carried by b.Info.Logger.
• Modernize packetbeat/beater/processor.go:81-83 to use WaitGroup.Go without a separate Add/Done pair.
• Replace the deprecated b.Manager.Start() call in packetbeat/beater/packetbeat.go with the 9.4-supported PreInit/PostInit manager lifecycle, preserving the existing cleanup behavior.
• Run the scoped Packetbeat lint/check commands and rerun this workflow.

Investigation details

Root Cause

The failure is a code-quality gate on the backport commit, not a runner or dependency failure. The same four findings are emitted by golangci-lint v2.12.2 on all three runners. The PR head contains the flagged patterns: global logging in Run, p.wg.Add(1) followed by p.wg.Go, and b.Manager.Start() in the managed run path.

Evidence

• Workflow: https://github.com/elastic/beats/actions/runs/30254574431
• Failed jobs/step: lint (ubuntu-latest), lint (windows-latest), and lint (macos-latest), step golangci-lint
• Key log excerpt: packetbeat/beater/packetbeat.go:166:6 and :183:4: use of logp.L forbidden; packetbeat/beater/processor.go:81:2: waitgroupgo (Goroutine creation can be simplified using WaitGroup.Go); packetbeat/beater/packetbeat.go:226:12: SA1019: b.Manager.Start is deprecated: Use [PreInit] and [PostInit] instead.

Validation

No tests were run; this was a read-only workflow-log investigation. The three platform jobs independently reported the same four findings.

Follow-up

After applying the changes, rerun the golangci-lint workflow and confirm all three platform jobs pass.

---

What is this? | From workflow: PR Actions Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

[khushijain21]

This PR requires backport of #51136. Which is not planned. Hence closing this PR