Making rendering useful for formatting files (2)

[ekrich]

I messed up adding to your PR @kastoestoramadus

See #438

Just looking into this and rendering is a very popular topic and never tackled. I think we need to review and be confident we are not getting into a can of worms unless you plan to help me on some of the render issues and requests.

I am still leaning towards accepting this PR but would like you thought on some of the issues raised and other issues and PRs already brought up.

PRs

• #806 Skip ignoredWhitespaces when rendering concatenation lightbend/config#809 Open PR
• Rendering a parsed config does not hold same results lightbend/config#805 Open PR
  Issues
• Rendering partially resolved appended array results in invalid configuration lightbend/config#800
• Address long standing ordering/sorting issues. lightbend/config#733 Great Discussion
• rendered keys of an object should be sorted alphanumerically lightbend/config#228 Fixed for alpha numeric ordering
  Search
  https://github.com/lightbend/config/issues?q=is%3Aissue%20state%3Aopen%20render

[ekrich]

Ping @kastoestoramadus - what do you think?

[kastoestoramadus]

Sure, not sure if I fix all of them but will solve some of them.
Thanks.

[ekrich]

I made some changes to your code - they look ok? I was just pointing out that we are going a new direction and there could be some bumps in the road. Maybe the lightbend library will accept your changes but who knows. Let me know how it goes with your tool after I make a release.

[kastoestoramadus]

👍

[kastoestoramadus]

plus you've covered defaults with tests. Your changes look good

[kastoestoramadus]

Polish Scala community said not to count on Lightbend with their library.
Accpeted are only some version bumps of dependant libs and from known people only.

[kastoestoramadus]

With my current employer I got some spare time at work. I'll look from time to time to this repo to help a bit.
I've added some comments to poeple in old repo. Maybe they'll contribute as well :).
Lets give them some time to react with their issues.

[ekrich]

Thanks for the review. They finally recently took new changes.

[ekrich]

Can be tested using 1.11.0-SNAPSHOT.

[ekrich]

@kastoestoramadus Sorry to bug you but I think I would have to add this feature before I can release to maintain source compatibility with lightbend/config with this PR as seen here - lightbend/config#798

They added a boolean before your latest rendering edition. I do have a Discord for sconfig - see link on main README.md or here if you do Discord. https://discord.gg/pKUzfFNq - Otherwise, I created an issue if you have any suggestions or comments - I can do the change. Issue: #455

[kastoestoramadus]

@ekrich ok, will do it. Starting the work on it.