Add timeframe splitting framework to EICrecon #2824
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| set(PLUGIN_NAME "algorithms_event_building") | ||
|
|
||
| # Function creates ${PLUGIN_NAME}_plugin and ${PLUGIN_NAME}_library targets | ||
| # Setting default includes, libraries and installation paths | ||
| plugin_headers_only(${PLUGIN_NAME}) | ||
|
|
||
| # Find dependencies | ||
| plugin_add_algorithms(${PLUGIN_NAME}) |
|
ruse-traveler marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // SPDX-License-Identifier: LGPL-3.0-or-later | ||
| // Copyright (C) 2026 Takuya Kumaoka | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <algorithm> | ||
| #include <cmath> | ||
| #include <string_view> | ||
| #include <vector> | ||
|
|
||
| #include <algorithms/algorithm.h> | ||
|
|
||
| #include "algorithms/interfaces/WithPodConfig.h" | ||
| #include "algorithms/event_building/HitTimeAlignmentConfig.h" | ||
|
|
||
| namespace eicrecon { | ||
|
|
||
| template <typename HitT> | ||
| using HitTimeAlignmentAlgorithm = | ||
| algorithms::Algorithm<algorithms::Input<const typename HitT::collection_type>, | ||
| algorithms::Output<typename HitT::collection_type>>; | ||
|
|
||
| template <typename HitT> | ||
| class HitTimeAlignment : public HitTimeAlignmentAlgorithm<HitT>, | ||
| public WithPodConfig<HitTimeAlignmentConfig> { | ||
| public: | ||
| using AlgorithmT = HitTimeAlignmentAlgorithm<HitT>; | ||
|
|
||
| explicit HitTimeAlignment(std::string_view name) | ||
| : AlgorithmT{name, | ||
| {"inputHits"}, | ||
| {"outputHits"}, | ||
| "Correct reconstructed hit times for propagation and sort by time."} {} | ||
|
|
||
| void init() final {} | ||
|
|
||
| void process(const typename AlgorithmT::Input& input, | ||
| const typename AlgorithmT::Output& output) const final { | ||
| const auto [hits_in] = input; | ||
| auto [hits_out] = output; | ||
|
|
||
| std::vector<typename HitT::mutable_type> sorted_hits; | ||
| sorted_hits.reserve(hits_in->size()); | ||
| for (const auto& hit : *hits_in) { | ||
| auto copied_hit = hit.clone(); | ||
| const auto position = hit.getPosition(); | ||
| const auto radius = std::sqrt(position[0] * position[0] + position[1] * position[1] + | ||
| position[2] * position[2]); | ||
| const auto average_time_of_flight = radius * this->m_cfg.reference_inverse_velocity; | ||
| copied_hit.setTime(hit.getTime() - average_time_of_flight); | ||
| sorted_hits.push_back(copied_hit); | ||
| } | ||
|
|
||
| std::stable_sort(sorted_hits.begin(), sorted_hits.end(), [](const auto& lhs, const auto& rhs) { | ||
|
Contributor
There was a problem hiding this comment. Just in case someone has the same thought, the size of a hit here is typically < 64 bytes so a hit fits in an L1 cache line and so there is no benefit to sort an iota to avoid the move costs. Microbenchmark could be useful but not necessary since likely not a major impact on performance here at this point. |
||
| return lhs.getTime() < rhs.getTime(); | ||
| }); | ||
|
|
||
| for (const auto& hit : sorted_hits) { | ||
| hits_out->push_back(hit); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| } // namespace eicrecon | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // SPDX-License-Identifier: LGPL-3.0-or-later | ||
| // Copyright (C) 2026 Takuya Kumaoka | ||
|
|
||
| #pragma once | ||
|
|
||
| namespace eicrecon { | ||
|
|
||
| struct HitTimeAlignmentConfig { | ||
| double reference_inverse_velocity = | ||
| 0.0034; //< ns/mm estimated by MC average time of flight / distance from IP to calorimeter | ||
| }; | ||
|
|
||
| } // namespace eicrecon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused?