Allow truth seeder to work with secondary particles - #2797
Merged
Conversation
Contributor
|
FYI @AkshayaVijay this is a very similar kind of question as to what particle caused a cluster. Maybe the logic of navigating up the MCParticle graph can be shared between this and the cluster links determination. |
veprbl
pushed a commit
that referenced
this pull request
Jul 30, 2026
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/30388662690. Please merge this PR into the branch `pr/truth-init-accepts-all` to resolve failures in PR #2797. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
veprbl
reviewed
Jul 30, 2026
Contributor
Capybara summary for PR 2797
Last updated 2026-08-12T18:34-04:00 0f53b66 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets EICrecon’s truth-based track seeding (TrackParamTruthInit) to allow seeding of Geant4-produced secondary particles (e.g., decay products) by relaxing the previous hard requirement on generatorStatus == 1.
Changes:
- Updates the MCParticle filtering logic to accept either generator-stable particles or simulation-produced secondaries (via
simulatorStatus). - Expands trace logging to include both generator and simulator status for rejected particles.
- Cleans up and adjusts includes (removing unused headers and adding
<tuple>).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
veprbl
approved these changes
Aug 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 7, 2026
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/30388662690. Please merge this PR into the branch `pr/truth-init-accepts-all` to resolve failures in PR #2797. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wdconinc
force-pushed
the
pr/truth-init-accepts-all
branch
from
August 12, 2026 18:34
c983d09 to
0f53b66
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 18, 2026
Open
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Should fix part 1 of #2746 - allow TruthSeeder to seed secondary particles from e.g. lambdas
What is the urgency of this PR?
Current setup makes B0 not working for any decay products, for which (arguably) it is intended. In our case, for example, we can't see the most of Sullivan lambdas via proton+pi- channel (which is ~75% of lambda decays that leave a trace in our detector)
What kind of change does this PR introduce?
Please check if any of the following apply
Truth finder cuts
So 1 and 2 must go and 4 probably be changed in order to start seeding secondaries. But this will probably change all pictures that use TruthSeeding and this must be especially seen in background populated frames reconstruction