Skip to content

fix: Revert "fix: remove t-algorithms-test" #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wdconinc wants to merge 9 commits into
base: main
Choose a base branch
from
+48 −0
Draft

fix: Revert "fix: remove t-algorithms-test" #2557

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
992ed94
Initial plan
Copilot Mar 11, 2026
6968791
ci: separate t_algorithms_test into its own CI job
Copilot Mar 11, 2026
492d5e3
fix: remove t-algorithms-test
wdconinc Mar 11, 2026
1c27733
fix: tighten test regex
wdconinc Mar 11, 2026
c2fb86c
fix: don't upload test binary
wdconinc Mar 11, 2026
b4b0d69
Revert "fix: remove t-algorithms-test"
wdconinc Mar 11, 2026
7776c88
Revert "fix: don't upload test binary"
wdconinc Mar 11, 2026
de1b680
Use ctest to run t_algorithms_test in CI workflow (#2558)
Copilot Mar 11, 2026
65fc5e6
Merge branch 'main' into copilot/exclude-t-algorithms-test-revert
wdconinc Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .github/workflows/linux-eic-shell.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,17 @@ jobs:
name: install-${{ matrix.CXX }}-eic-shell-${{ matrix.CMAKE_BUILD_TYPE }}-${{ env.platform }}-${{ matrix.release }}-ASAN
path: install.tar.zst
if-no-files-found: error
# Only compress and upload build directory for t_algorithms_test if we are going to use it later
- name: Compress build directory (for t_algorithms_test)
if: ${{ matrix.CXX == 'clang++' && matrix.CMAKE_BUILD_TYPE == 'Release' && matrix.USE_ASAN == 'ON' && matrix.USE_TSAN == 'OFF' }}
run: tar -caf build-t-algorithms-test.tar.zst $(find build -name "CTestTestfile.cmake") build/src/tests/algorithms_test/algorithms_test
- name: Upload build directory (for t_algorithms_test)
if: ${{ matrix.CXX == 'clang++' && matrix.CMAKE_BUILD_TYPE == 'Release' && matrix.USE_ASAN == 'ON' && matrix.USE_TSAN == 'OFF' }}
uses: actions/upload-artifact@v7
with:
name: build-t-algorithms-test-${{ matrix.CXX }}-eic-shell-${{ matrix.CMAKE_BUILD_TYPE }}-${{ env.platform }}-${{ matrix.release }}-ASAN
path: build-t-algorithms-test.tar.zst
Comment on lines +221 to +229
if-no-files-found: error
- name: Upload install directory (TSAN)
if: ${{ matrix.USE_ASAN == 'OFF' && matrix.USE_TSAN == 'ON' }}
uses: actions/upload-artifact@v7
Expand All @@ -236,6 +247,43 @@ jobs:
path: build.tar.zst
if-no-files-found: error

t-algorithms-test:
# This job runs t_algorithms_test separately from the build job.
# It specifically targets the clang++ Release ASAN configuration that was failing.
runs-on: ubuntu-24.04
needs:
- build
Comment thread
wdconinc marked this conversation as resolved.
continue-on-error: true
steps:
- name: Checkout .github
uses: actions/checkout@v6
with:
sparse-checkout: .github
- uses: cvmfs-contrib/github-action-cvmfs@v5
- name: Download install directory
uses: actions/download-artifact@v8
with:
name: install-clang++-eic-shell-Release-${{ env.platform }}-${{ env.release }}-ASAN
- name: Uncompress install directory
run: tar -xaf install.tar.zst
- name: Download build directory (for t_algorithms_test)
uses: actions/download-artifact@v8
with:
name: build-t-algorithms-test-clang++-eic-shell-Release-${{ env.platform }}-${{ env.release }}-ASAN
- name: Uncompress build directory
run: tar -xaf build-t-algorithms-test.tar.zst
- name: Run t_algorithms_test
uses: eic/run-cvmfs-osg-eic-shell@main
with:
organization: "${{ env.organization }}"
platform-release: "${{ env.platform }}:${{ env.release }}"
run: |
# GitHub Actions artifacts do not preserve file permissions
chmod +x build/src/tests/algorithms_test/algorithms_test
export LD_LIBRARY_PATH=$PWD/install/lib:$LD_LIBRARY_PATH
export JANA_PLUGIN_PATH=$PWD/install/lib/EICrecon/plugins${JANA_PLUGIN_PATH:+:${JANA_PLUGIN_PATH}}
ctest --test-dir build -V -R "^t_algorithms_test$"

clang-tidy-iwyu:
runs-on: ubuntu-24.04
needs: build
Expand Down
Loading